Funivan\Console\SingleState\SingleStateConfigurator::configureSingleState()

Complexity

Conditions	7
Paths	1

Size

Total Lines	36
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	56

Importance

Changes

0

<?php
    public function configureSingleState(EventDispatcher $dispatcher) {
      $dispatcher->addListener(ConsoleEvents::COMMAND, function (ConsoleCommandEvent $event) {

        /** @var ConsoleCommand $command */
        $command = $event->getCommand();

        if (!($command instanceof ConsoleCommand) or ($command->isSingleInstance() == false)) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

          return;
        }


        $commandState = (new CommandState($command));
        if ($commandState->isAlive()) {
          $event->getOutput()->writeln('Already running: ' . $command->getName() . ' Pid:' . $commandState->getPid());
          $event->disableCommand();
        } else {
          $commandState->setPid(getmypid());
        }

      });

      $dispatcher->addListener(ConsoleEvents::TERMINATE, function (ConsoleTerminateEvent $event) {
        /** @var ConsoleCommand $command */
        $command = $event->getCommand();

        if (!($command instanceof ConsoleCommand) or ($command->isSingleInstance() == false)) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

          return;
        }

        if ($event->getExitCode() === 0) {
          (new CommandState($command))->unlink();
        }

      });
      return $dispatcher;
    }
  }