Fiv\Collection\ObjectCollection

Complexity

Total Complexity

5

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
	objectsClassName()	0	1	?
A	__clone()	0	7	2
A	validateType()	0	7	3

<?php

  namespace Fiv\Collection;

  abstract class ObjectCollection extends TypedCollection {

    /**
     * Used for validation
     * Return class name
     *
     * @codeCoverageIgnore
     * @return string
     */
    public abstract function objectsClassName();

    /**
     * Clone each item
     */
    public function __clone() {
      $items = array();
      foreach ($this->items as $item) {
        $items[] = clone $item;
      }
      $this->setItems($items);
    }


    public function validateType($item) {
      $itemClass = $this->objectsClassName();
      if (($item instanceof $itemClass) == false) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

        $className = ($item === null) ? null : get_class($item);
        throw new \Exception('Invalid object type. Expect ' . $this->objectsClassName() . ' given ' . $className);
      }
    }

  }