MethodPattern - Code Metrics - Inspection of "Now method can accept parameter pattern to filter..." - funivan/PhpTokenizer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a14e1b...dc020a )

by Shcherbak

created 2016-03-18 14:10 UTC

MethodPattern B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	366
Duplicated Lines	0 %

Coupling/Cohesion

Components	6
Dependencies	6

Test Coverage

Coverage

97.26%

Importance

Changes	3
Bugs	1	Features	0

Metric	Value
wmc	40
c	3
b	1
f	0
lcom	6
cbo	6
dl	0
loc	366
ccs	142
cts	146
cp	0.9726
rs	7.6

17 Methods

Rating	Name	Size	Complexity
A	__construct()	15	1
A	outputFull()	4	1
A	outputBody()	4	1
A	outputDocComment()	4	1
A	withName()	11	3
A	withBody()	4	1
A	isValidBody()	9	2
A	withDocComment()	11	2
A	withoutDocComment()	7	1
A	withParameters()	4	1
A	withAnyModifier()	7	1
A	withModifier()	7	1
A	withoutModifier()	8	1
A	isValidModifiers()	14	4
D	__invoke()	97	15
A	isValidDocComment()	9	2
A	isValidParameters()	11	2

How to fix Complexity

<?php

  namespace Funivan\PhpTokenizer\Pattern\Patterns;

  use Funivan\PhpTokenizer\Collection;
  use Funivan\PhpTokenizer\Pattern\Pattern;
  use Funivan\PhpTokenizer\QuerySequence\QuerySequence;
  use Funivan\PhpTokenizer\Strategy\QueryStrategy;
  use Funivan\PhpTokenizer\Strategy\Strict;
  use Funivan\PhpTokenizer\Token;

  /**
   * Find method in code
   */
  class MethodPattern implements PatternInterface {

    const OUTPUT_BODY = 0;

    const OUTPUT_FULL = 1;

    const OUTPUT_DOC_COMMENT = 2;


    /**
     * @var QueryStrategy
     */
    private $nameQuery;

    /**
     * @var callable[]
     */
    private $modifierChecker = [];

    /**
     * @var callable
     */
    private $bodyChecker;

    /**
     * @var callable
     */
    private $docCommentChecker;

    /**
     * @var int
     */
    private $outputType = self::OUTPUT_BODY;

    /**
     * @var ParametersPattern
     */
    private $parametersPattern;


    /**
     *
     */
    public function __construct() {
      $this->withName(Strict::create()->valueLike('!.+!'));
      $this->withAnyModifier();

      /** @noinspection PhpUnusedParameterInspection */
      $this->withBody(function (Collection $body) {
        return true;
      });

      /** @noinspection PhpUnusedParameterInspection */
      $this->withDocComment(function (Token $token) {
        return true;
      });

    }


    /**
     * @return $this
     */
    public function outputFull() {
      $this->outputType = self::OUTPUT_FULL;
      return $this;
    }


    /**
     * @return $this
     */
    public function outputBody() {
      $this->outputType = self::OUTPUT_BODY;
      return $this;
    }


    /**
     * @return $this
     */
    public function outputDocComment() {
      $this->outputType = self::OUTPUT_DOC_COMMENT;
      return $this;
    }


    /**
     * @param string|QueryStrategy $name
     * @return $this
     */
    public function withName($name) {
      if (is_string($name)) {
        $this->nameQuery = Strict::create()->valueIs($name);
      } elseif ($name instanceof QueryStrategy) {
        $this->nameQuery = $name;
      } else {
        throw new \InvalidArgumentException('Invalid name format. Expect string or Query');
      }

      return $this;
    }


    /**
     * @param callable $check
     * @return $this
     */
    public function withBody(callable $check) {
      $this->bodyChecker = $check;
      return $this;
    }


    /**
     * @param Collection $body
     * @return bool
     * @throws \Exception
     */
    private function isValidBody(Collection $body) {
      $checker = $this->bodyChecker;
      $result = $checker($body);
      if (!is_bool($result)) {
        throw new \Exception('Body checker should return boolean result');
      }

      return $result;
    }


    /**
     * @param callable $check
     * @return $this
     */
    public function withDocComment(callable $check = null) {

      if ($check === null) {
        $check = function (Token $token) {
          return $token->getType() === T_DOC_COMMENT;
        };
      }
      $this->docCommentChecker = $check;

      return $this;
    }


    /**
     * Find functions without doc comments
     */
    public function withoutDocComment() {
      $this->docCommentChecker = function (Token $token) {
        return $token->isValid() === false;
      };

      return $this;
    }


    /**
     * @param ParametersPattern $pattern
     * @return $this
     */
    public function withParameters(ParametersPattern $pattern) {
      $this->parametersPattern = $pattern;
      return $this;
    }


    /**
     * @return $this
     */
    public function withAnyModifier() {
      $this->modifierChecker = [];
      $this->modifierChecker[] = function () {
        return true;
      };
      return $this;
    }


    /**
     * @param string $modifier
     * @return $this
     */
    public function withModifier($modifier) {
      $this->modifierChecker[] = function ($allModifiers) use ($modifier) {
        return in_array($modifier, $allModifiers);
      };

      return $this;
    }


    /**
     * @param string $modifier
     * @return $this
     */
    public function withoutModifier($modifier) {

      $this->modifierChecker[] = function ($allModifiers) use ($modifier) {
        return !in_array($modifier, $allModifiers);
      };

      return $this;
    }


    /**
     * @param array $modifiers Array<String>
     * @return bool
     * @throws \Exception
     */
    private function isValidModifiers(array $modifiers) {
      foreach ($this->modifierChecker as $checkModifier) {
        $result = $checkModifier($modifiers);

        if (!is_bool($result)) {
          throw new \Exception('Modifier checker should return boolean result');
        }
        if ($result === false) {
          return false;
        }
      }

      return true;
    }


    /**
     * @param QuerySequence $querySequence
     * @return Collection|null
     */
    public function __invoke(QuerySequence $querySequence) {
      static $availableModifiers = [
        T_STATIC,
        T_PRIVATE,
        T_PUBLIC,
        T_ABSTRACT,
        T_FINAL,
      ];


      # detect function
      $functionKeyword = $querySequence->strict('function');
      $querySequence->strict(T_WHITESPACE);
      $querySequence->process($this->nameQuery);
      $parameters = $querySequence->section('(', ')');
      $querySequence->possible(T_WHITESPACE);
      $body = $querySequence->section('{', '}');

      if (!$querySequence->isValid()) {
        return null;
      }

      $collection = $querySequence->getCollection();
      $start = $collection->extractByTokens($collection->getFirst(), $functionKeyword);
      $start->slice(0, -1);  // remove last function keyword

      # start reverse search
      $items = array_reverse($start->getItems());
      $startFrom = null;

      $docComment = new Token();

      $modifiers = [];


      /** @var Token[] $items */
      foreach ($items as $item) {

        if ($item->getType() === T_WHITESPACE) {
          $startFrom = $item;
          continue;
        }

        if ($item->getType() === T_DOC_COMMENT and $docComment->isValid() === false) {
          # Detect only first doc comment
          $startFrom = $item;
          $docComment = $item;
          continue;
        }


        if (in_array($item->getType(), $availableModifiers)) {
          $startFrom = $item;
          $modifiers[] = $item->getValue();
          continue;
        }

        break;
      }

      if ($this->isValidModifiers($modifiers) === false) {
        return null;
      }

      if ($this->isValidBody($body) === false) {
        return null;
      }

      if ($this->isValidDocComment($docComment) === false) {
        return null;
      }

      if ($this->isValidParameters($parameters) === false) {
        return null;
      }

      if ($startFrom === null) {
        $startFrom = $functionKeyword;
      }


      if ($this->outputType === self::OUTPUT_FULL) {
        # all conditions are ok, so extract full function
        $fullFunction = $collection->extractByTokens($startFrom, $body->getLast());
        if ($fullFunction->getFirst()->getType() === T_WHITESPACE) {
          $fullFunction->slice(1);
        }
        return $fullFunction;

      } elseif ($this->outputType === self::OUTPUT_DOC_COMMENT) {
        return new Collection([$docComment]);
      }

      # body by default
      $body->slice(0, -1);
      return $body;
    }


    /**
     * @param Token $token
     * @return mixed
     * @throws \Exception
     */
    private function isValidDocComment(Token $token) {
      $checker = $this->docCommentChecker;
      $result = $checker($token);
      if (!is_bool($result)) {
        throw new \Exception('DocComment checker should return boolean result');
      }

      return $result;
    }


    /**
     * @param Collection $parameters
     * @return bool
     */
    private function isValidParameters(Collection $parameters) {
      if ($this->parametersPattern === null) {
        return true;
      }

      $this->parametersPattern->startFromParenthesis();

      $pattern = (new Pattern($parameters))->apply($this->parametersPattern);

      return (count($pattern->getCollections()) !== 0);
    }


  }

1		<?php
2
3		namespace Funivan\PhpTokenizer\Pattern\Patterns;
4
5		use Funivan\PhpTokenizer\Collection;
6		use Funivan\PhpTokenizer\Pattern\Pattern;
7		use Funivan\PhpTokenizer\QuerySequence\QuerySequence;
8		use Funivan\PhpTokenizer\Strategy\QueryStrategy;
9		use Funivan\PhpTokenizer\Strategy\Strict;
10		use Funivan\PhpTokenizer\Token;
11
12		/**
13		* Find method in code
14		*/
15		class MethodPattern implements PatternInterface {
16
17		const OUTPUT_BODY = 0;
18
19		const OUTPUT_FULL = 1;
20
21		const OUTPUT_DOC_COMMENT = 2;
22
23
24		/**
25		* @var QueryStrategy
26		*/
27		private $nameQuery;
28
29		/**
30		* @var callable[]
31		*/
32		private $modifierChecker = [];
33
34		/**
35		* @var callable
36		*/
37		private $bodyChecker;
38
39		/**
40		* @var callable
41		*/
42		private $docCommentChecker;
43
44		/**
45		* @var int
46		*/
47		private $outputType = self::OUTPUT_BODY;
48
49		/**
50		* @var ParametersPattern
51		*/
52		private $parametersPattern;
53
54
55		/**
56		*
57		*/
58	21	public function __construct() {
59	18	$this->withName(Strict::create()->valueLike('!.+!'));
60	18	$this->withAnyModifier();
61
62		/** @noinspection PhpUnusedParameterInspection */
63		$this->withBody(function (Collection $body) {
64	17	return true;
65	18	});
66
67		/** @noinspection PhpUnusedParameterInspection */
68		$this->withDocComment(function (Token $token) {
69	17	return true;
70	18	});
71
72	21	}
73
74
75		/**
76		* @return $this
77		*/
78	3	public function outputFull() {
79	3	$this->outputType = self::OUTPUT_FULL;
80	3	return $this;
81		}
82
83
84		/**
85		* @return $this
86		*/
87	3	public function outputBody() {
88	3	$this->outputType = self::OUTPUT_BODY;
89	3	return $this;
90		}
91
92
93		/**
94		* @return $this
95		*/
96	3	public function outputDocComment() {
97	3	$this->outputType = self::OUTPUT_DOC_COMMENT;
98	3	return $this;
99		}
100
101
102		/**
103		* @param string\|QueryStrategy $name
104		* @return $this
105		*/
106	21	public function withName($name) {
107	18	if (is_string($name)) {
108	2	$this->nameQuery = Strict::create()->valueIs($name);
109	11	} elseif ($name instanceof QueryStrategy) {
110	21	$this->nameQuery = $name;
111	9	} else {
112	2	throw new \InvalidArgumentException('Invalid name format. Expect string or Query');
113	3	}
114
115	21	return $this;
116		}
117
118
119		/**
120		* @param callable $check
121		* @return $this
122		*/
123	21	public function withBody(callable $check) {
124	21	$this->bodyChecker = $check;
125	21	return $this;
126	3	}
127
128
129		/**
130		* @param Collection $body
131		* @return bool
132		* @throws \Exception
133		*/
134	17	private function isValidBody(Collection $body) {
135	17	$checker = $this->bodyChecker;
136	16	$result = $checker($body);
137	16	if (!is_bool($result)) {
138		throw new \Exception('Body checker should return boolean result');
139		}
140
141	17	return $result;
142	1	}
143
144
145		/**
146		* @param callable $check
147		* @return $this
148		*/
149	21	public function withDocComment(callable $check = null) {
150
151	21	if ($check === null) {
152		$check = function (Token $token) {
153	2	return $token->getType() === T_DOC_COMMENT;
154	2	};
155	1	}
156	21	$this->docCommentChecker = $check;
157
158	21	return $this;
159	3	}
160
161
162		/**
163		* Find functions without doc comments
164		*/
165	3	public function withoutDocComment() {
166		$this->docCommentChecker = function (Token $token) {
167	2	return $token->isValid() === false;
168		};
169
170	3	return $this;
171		}
172
173
174		/**
175		* @param ParametersPattern $pattern
176		* @return $this
177		*/
178	2	public function withParameters(ParametersPattern $pattern) {
179	2	$this->parametersPattern = $pattern;
180	2	return $this;
181		}
182
183
184		/**
185		* @return $this
186		*/
187	21	public function withAnyModifier() {
188	21	$this->modifierChecker = [];
189		$this->modifierChecker[] = function () {
190	17	return true;
191	3	};
192	21	return $this;
193		}
194
195
196		/**
197		* @param string $modifier
198		* @return $this
199		*/
200	2	public function withModifier($modifier) {
201		$this->modifierChecker[] = function ($allModifiers) use ($modifier) {
202	2	return in_array($modifier, $allModifiers);
203		};
204
205	2	return $this;
206		}
207
208
209		/**
210		* @param string $modifier
211		* @return $this
212		*/
213		public function withoutModifier($modifier) {
214
215	3	$this->modifierChecker[] = function ($allModifiers) use ($modifier) {
216	2	return !in_array($modifier, $allModifiers);
217	1	};
218
219	3	return $this;
220		}
221
222
223		/**
224		* @param array $modifiers Array<String>
225		* @return bool
226		* @throws \Exception
227		*/
228	17	private function isValidModifiers(array $modifiers) {
229	17	foreach ($this->modifierChecker as $checkModifier) {
230	16	$result = $checkModifier($modifiers);
231
232	16	if (!is_bool($result)) {
233		throw new \Exception('Modifier checker should return boolean result');
234		}
235	17	if ($result === false) {
236	9	return false;
237		}
238	8	}
239
240	17	return true;
241	1	}
242
243
244		/**
245		* @param QuerySequence $querySequence
246		* @return Collection\|null
247		*/
248	18	public function __invoke(QuerySequence $querySequence) {
249	8	static $availableModifiers = [
250	1	T_STATIC,
251	1	T_PRIVATE,
252	1	T_PUBLIC,
253	1	T_ABSTRACT,
254	1	T_FINAL,
255	8	];
256
257
258		# detect function
259	16	$functionKeyword = $querySequence->strict('function');
260	16	$querySequence->strict(T_WHITESPACE);
261	16	$querySequence->process($this->nameQuery);
262	16	$parameters = $querySequence->section('(', ')');
263	16	$querySequence->possible(T_WHITESPACE);
264	16	$body = $querySequence->section('{', '}');
265
266	16	if (!$querySequence->isValid()) {
267	16	return null;
268		}
269
270	16	$collection = $querySequence->getCollection();
271	16	$start = $collection->extractByTokens($collection->getFirst(), $functionKeyword);
272	16	$start->slice(0, -1); // remove last function keyword
273
274		# start reverse search
275	16	$items = array_reverse($start->getItems());
276	17	$startFrom = null;
277
278	16	$docComment = new Token();
279
280	17	$modifiers = [];
281
282
283		/** @var Token[] $items */
284	16	foreach ($items as $item) {
285
286	16	if ($item->getType() === T_WHITESPACE) {
287	14	$startFrom = $item;
288	14	continue;
289		}
290
291	16	if ($item->getType() === T_DOC_COMMENT and $docComment->isValid() === false) {
292		# Detect only first doc comment
293	4	$startFrom = $item;
294	4	$docComment = $item;
295	4	continue;
296		}
297
298
299	16	if (in_array($item->getType(), $availableModifiers)) {
300	10	$startFrom = $item;
301	10	$modifiers[] = $item->getValue();
302	10	continue;
303		}
304
305	18	break;
306	9	}
307
308	16	if ($this->isValidModifiers($modifiers) === false) {
309	2	return null;
310		}
311
312	16	if ($this->isValidBody($body) === false) {
313	2	return null;
314		}
315
316	16	if ($this->isValidDocComment($docComment) === false) {
317	2	return null;
318		}
319
320	16	if ($this->isValidParameters($parameters) === false) {
321	3	return null;
322		}
323
324	17	if ($startFrom === null) {
325	3	$startFrom = $functionKeyword;
326	1	}
327
328
329	17	if ($this->outputType === self::OUTPUT_FULL) {
330		# all conditions are ok, so extract full function
331	2	$fullFunction = $collection->extractByTokens($startFrom, $body->getLast());
332	2	if ($fullFunction->getFirst()->getType() === T_WHITESPACE) {
333	2	$fullFunction->slice(1);
334	1	}
335	3	return $fullFunction;
336
337	17	} elseif ($this->outputType === self::OUTPUT_DOC_COMMENT) {
338	2	return new Collection([$docComment]);
339		}
340
341		# body by default
342	16	$body->slice(0, -1);
343	17	return $body;
344		}
345
346
347		/**
348		* @param Token $token
349		* @return mixed
350		* @throws \Exception
351		*/
352	17	private function isValidDocComment(Token $token) {
353	17	$checker = $this->docCommentChecker;
354	16	$result = $checker($token);
355	16	if (!is_bool($result)) {
356		throw new \Exception('DocComment checker should return boolean result');
357		}
358
359	17	return $result;
360	1	}
361
362
363		/**
364		* @param Collection $parameters
365		* @return bool
366		*/
367	17	private function isValidParameters(Collection $parameters) {
368	17	if ($this->parametersPattern === null) {
369	15	return true;
370		}
371
372	2	$this->parametersPattern->startFromParenthesis();
373
374	2	$pattern = (new Pattern($parameters))->apply($this->parametersPattern);
375
376	2	return (count($pattern->getCollections()) !== 0);
377	1	}
378
379
380		}

funivan / PhpTokenizer

Push — master ( a14e1b...dc020a )

MethodPattern B

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

17 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like