Funivan\Cs\Fs\FileFinder\StandardFileFinder::findFiles()

Complexity

Conditions	9
Paths	13

Size

Total Lines	61
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	90

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function findFiles(FinderParameters $finderParameters) {
      $filesCollection = new FilesCollection();

      if ($finderParameters->get('dir')) {

The expression $finderParameters->get('dir') of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

        $dir = $finderParameters->get('dir');

        $files = (new Finder())->in($dir)->files();

        /** @var SplFileInfo $file */
        foreach ($files as $file) {
          $filesCollection->add(new File($file->getRealPath(), File::STATUS_UNKNOWN));
        }

        return $filesCollection;
      }

      $baseDir = $finderParameters->get('baseDir');
      if (empty($baseDir)) {
        throw new \RuntimeException('Can not find files. Invalid baseDir finder parameter.');
      }
      $baseDir = rtrim($baseDir, DIRECTORY_SEPARATOR) . DIRECTORY_SEPARATOR;
      if (!empty($commitHash)) {

The variable $commitHash seems to never exist, and therefore empty should always return true. Did you maybe rename this variable?

        $process = new Process('git diff-tree --no-commit-id --name-status  -r ' . $commitHash);
      } else {
        $process = new Process('git diff --name-status ; git diff --cached --name-status');
      }


      $process->run();
      if (!$process->isSuccessful()) {
        return $filesCollection;
      }


      $filesList = array_filter(explode("\n", $process->getOutput()));

      $statusMap = [
        'A' => File::STATUS_ADDED,
        'C' => File::STATUS_COPIED,
        'M' => File::STATUS_MODIFIED,
        'R' => File::STATUS_RENAMED,
        'D' => File::STATUS_DELETED,
      ];

      foreach ($filesList as $fileInfo) {

        preg_match('!^([^\s]+)\s+(.+)$!', $fileInfo, $matchedFileInfo);
        if (empty($matchedFileInfo[2])) {
          continue;
        }
        $gitStatus = trim($matchedFileInfo[1]);

        $status = !empty($statusMap[$gitStatus]) ? $statusMap[$gitStatus] : File::STATUS_UNKNOWN;

        $fullPath = $baseDir . ltrim($matchedFileInfo[2], DIRECTORY_SEPARATOR);
        $filesCollection->add(new File($fullPath, $status));
      }

      return $filesCollection;

    }

  }