ToolsFilter - Code Metrics - Inspection of "remove file finder factory. Move composer to stand..." - funivan/Cs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 119a25...af28eb )

by Shcherbak

created 2016-06-15 10:10 UTC

ToolsFilter A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	68
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	68
wmc	9
lcom	1
cbo	1
ccs	0
cts	22
cp	0
rs	10

5 Methods

Rating	Name	Size	Complexity
A	getInclude()	3	1
A	setInclude()	3	1
A	getExclude()	3	1
A	setExclude()	3	1
B	isValid()	15	5

<?php

  namespace Funivan\Cs\FileTool;

  /**
   * @author Ivan Shcherbak <[email protected]> 2016
   */
  class ToolsFilter {

    /**
     * @var null|string[]
     */
    private $include = null;

    /**
     * @var null|string[]
     */
    private $exclude = null;


    /**
     * @return null|string[]
     */
    public function getInclude() {
      return $this->include;
    }


    /**
     * @param null|string[] $include
     * @return $this
     */
    public function setInclude(array $include = null) {
      $this->include = $include;
    }


    /**
     * @return null|\string[]
     */
    public function getExclude() {
      return $this->exclude;
    }


    /**
     * @param null|\string[] $exclude
     * @return $this
     */
    public function setExclude(array $exclude = null) {
      $this->exclude = $exclude;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }


    /**
     * @param FileTool $tool
     * @return bool
     */
    public function isValid(FileTool $tool) {

      $toolName = $tool->getName();

      if (null !== $this->exclude and in_array($toolName, $this->exclude)) {
        return false;
      }

      if (null !== $this->include and !in_array($toolName, $this->include)) {
        return false;
      }


      return true;
    }

  }

1			<?php
2
3			namespace Funivan\Cs\FileTool;
4
5			/**
6			* @author Ivan Shcherbak <[email protected]> 2016
7			*/
8			class ToolsFilter {
9
10			/**
11			* @var null\|string[]
12			*/
13			private $include = null;
14
15			/**
16			* @var null\|string[]
17			*/
18			private $exclude = null;
19
20
21			/**
22			* @return null\|string[]
23			*/
24			public function getInclude() {
25			return $this->include;
26			}
27
28
29			/**
30			* @param null\|string[] $include
31			* @return $this
32			*/
33			public function setInclude(array $include = null) {
34			$this->include = $include;
35			}
36
37
38			/**
39			* @return null\|\string[]
40			*/
41			public function getExclude() {
42			return $this->exclude;
43			}
44
45
46			/**
47			* @param null\|\string[] $exclude
48			* @return $this
49			*/
50			public function setExclude(array $exclude = null) {
51			$this->exclude = $exclude;
			0 ignored issues – show Documentation Bug introduced 2016-06-15 10:14 UTC by Report Bug Copy Issue Report It seems like `$exclude` can also be of type `array<integer,object<string>>`. However, the property `$exclude` is declared as type `null\|array<integer,string>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
52			}
53
54
55			/**
56			* @param FileTool $tool
57			* @return bool
58			*/
59			public function isValid(FileTool $tool) {
60
61			$toolName = $tool->getName();
62
63			if (null !== $this->exclude and in_array($toolName, $this->exclude)) {
64			return false;
65			}
66
67			if (null !== $this->include and !in_array($toolName, $this->include)) {
68			return false;
69			}
70
71
72			return true;
73			}
74
75			}

funivan / Cs

Push — master ( 119a25...af28eb )

ToolsFilter A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

5 Methods

Duplication Side-by-Side

Filter issues like