StandardFileFinder::findFiles() - Code Metrics - funivan/Cs - Measure and Improve Code Quality continuously with Scrutinizer

StandardFileFinder::findFiles() C
last analyzed 2017-05-12 08:55 UTC

↳ Parent: StandardFileFinder

Complexity

Conditions	9
Paths	13

Size

Total Lines	62
Code Lines	36

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	90

Importance

Changes

Metric	Value
dl	0
loc	62
c	0
b	0
f	0
ccs	0
cts	45
cp	0
rs	6.6867
cc	9
eloc	36
nc	13
nop	1
crap	90

How to fix Long Method

<?php

  namespace Funivan\Cs\Fs\FileFinder;

  use Funivan\Cs\Fs\File;
  use Funivan\Cs\Fs\FilesCollection;
  use Symfony\Component\Finder\Finder;
  use Symfony\Component\Finder\SplFileInfo;
  use Symfony\Component\Process\Process;

  /**
   *
   */
  class StandardFileFinder implements FileFinderInterface {

    /**
     * @param FinderParameters $finderParameters
     * @return FilesCollection
     * @internal param FinderParameters $params
     */
    public function findFiles(FinderParameters $finderParameters) {
      $filesCollection = new FilesCollection();

      if ($finderParameters->get('dir') !== null) {
        $dir = $finderParameters->get('dir');

        $files = (new Finder())->in($dir)->files();

        /** @var SplFileInfo $file */
        foreach ($files as $file) {
          $filesCollection->add(new File($file->getRealPath(), File::STATUS_UNKNOWN));
        }

        return $filesCollection;
      }

      $baseDir = $finderParameters->get('baseDir');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
      if ($baseDir == null) {
        throw new \RuntimeException('Can not find files. Invalid baseDir finder parameter.');
      }
      $baseDir = rtrim($baseDir, DIRECTORY_SEPARATOR) . DIRECTORY_SEPARATOR;
      $commit = $finderParameters->get('commit');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
      if ($commit !== null) {
        $process = new Process('git diff-tree --no-commit-id --name-status  -r ' . $commit);
      } else {
        $process = new Process('git diff --name-status ; git diff --cached --name-status');
      }


      $process->run();
      if (!$process->isSuccessful()) {
        return $filesCollection;
      }


      $filesList = array_filter(explode("\n", $process->getOutput()));

      $statusMap = [
        'A' => File::STATUS_ADDED,
        'C' => File::STATUS_COPIED,
        'M' => File::STATUS_MODIFIED,
        'R' => File::STATUS_RENAMED,
        'D' => File::STATUS_DELETED,
      ];

      foreach ($filesList as $fileInfo) {

        preg_match('!^([^\s]+)\s+(.+)$!', $fileInfo, $matchedFileInfo);
        if (empty($matchedFileInfo[2])) {
          continue;
        }
        $gitStatus = trim($matchedFileInfo[1]);

        $status = !empty($statusMap[$gitStatus]) ? $statusMap[$gitStatus] : File::STATUS_UNKNOWN;

        $fullPath = $baseDir . ltrim($matchedFileInfo[2], DIRECTORY_SEPARATOR);
        $filesCollection->add(new File($fullPath, $status));
      }

      return $filesCollection;

    }

  }

1			<?php
2
3			namespace Funivan\Cs\Fs\FileFinder;
4
5			use Funivan\Cs\Fs\File;
6			use Funivan\Cs\Fs\FilesCollection;
7			use Symfony\Component\Finder\Finder;
8			use Symfony\Component\Finder\SplFileInfo;
9			use Symfony\Component\Process\Process;
10
11			/**
12			*
13			*/
14			class StandardFileFinder implements FileFinderInterface {
15
16			/**
17			* @param FinderParameters $finderParameters
18			* @return FilesCollection
19			* @internal param FinderParameters $params
20			*/
21			public function findFiles(FinderParameters $finderParameters) {
22			$filesCollection = new FilesCollection();
23
24			if ($finderParameters->get('dir') !== null) {
25			$dir = $finderParameters->get('dir');
26
27			$files = (new Finder())->in($dir)->files();
28
29			/** @var SplFileInfo $file */
30			foreach ($files as $file) {
31			$filesCollection->add(new File($file->getRealPath(), File::STATUS_UNKNOWN));
32			}
33
34			return $filesCollection;
35			}
36
37			$baseDir = $finderParameters->get('baseDir');
			0 ignored issues – show Bug introduced 2016-06-15 11:23 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$baseDir` is correct as `$finderParameters->get('baseDir')` (which targets `Funivan\Cs\Fs\FileFinder\FinderParameters::get()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
38			if ($baseDir == null) {
39			throw new \RuntimeException('Can not find files. Invalid baseDir finder parameter.');
40			}
41			$baseDir = rtrim($baseDir, DIRECTORY_SEPARATOR) . DIRECTORY_SEPARATOR;
42			$commit = $finderParameters->get('commit');
			0 ignored issues – show Bug introduced 2016-06-15 11:23 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$commit` is correct as `$finderParameters->get('commit')` (which targets `Funivan\Cs\Fs\FileFinder\FinderParameters::get()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
43			if ($commit !== null) {
44			$process = new Process('git diff-tree --no-commit-id --name-status -r ' . $commit);
45			} else {
46			$process = new Process('git diff --name-status ; git diff --cached --name-status');
47			}
48
49
50			$process->run();
51			if (!$process->isSuccessful()) {
52			return $filesCollection;
53			}
54
55
56			$filesList = array_filter(explode("\n", $process->getOutput()));
57
58			$statusMap = [
59			'A' => File::STATUS_ADDED,
60			'C' => File::STATUS_COPIED,
61			'M' => File::STATUS_MODIFIED,
62			'R' => File::STATUS_RENAMED,
63			'D' => File::STATUS_DELETED,
64			];
65
66			foreach ($filesList as $fileInfo) {
67
68			preg_match('!^([^\s]+)\s+(.+)$!', $fileInfo, $matchedFileInfo);
69			if (empty($matchedFileInfo[2])) {
70			continue;
71			}
72			$gitStatus = trim($matchedFileInfo[1]);
73
74			$status = !empty($statusMap[$gitStatus]) ? $statusMap[$gitStatus] : File::STATUS_UNKNOWN;
75
76			$fullPath = $baseDir . ltrim($matchedFileInfo[2], DIRECTORY_SEPARATOR);
77			$filesCollection->add(new File($fullPath, $status));
78			}
79
80			return $filesCollection;
81
82			}
83
84			}

funivan / Cs

StandardFileFinder::findFiles() C last analyzed 2017-05-12 08:55 UTC

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

StandardFileFinder::findFiles() C
last analyzed 2017-05-12 08:55 UTC