Fuel\Validation\Rule\Regex

Complexity

Total Complexity

6

Size/Duplication

Total Lines	68
Duplicated Lines	100 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes	3
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	validate()	11	11	3
A	setParameter()	10	10	2
A	getMessageParameters()	6	6	1

<?php
/**
 * @package   Fuel\Validation
 * @version   2.0
 * @author    Fuel Development Team
 * @license   MIT License
 * @copyright 2010 - 2013 Fuel Development Team
 * @link      http://fuelphp.com
 */

namespace Fuel\Validation\Rule;

use Fuel\Validation\AbstractRule;

/**
 * Checks that the given value matches the regex passed to setParameter()
 *
 * @package Fuel\Validation\Rule
 * @author  Fuel Devleopment Team
 *
 * @since 2.0
 */
class Regex extends AbstractRule

This class seems to be duplicated in your project.

{

	/**
	 * Contains the rule failure message
	 *
	 * @var string
	 */
	protected $message = 'The field does not match the given pattern.';

	/**
	 * @param mixed  $value Value to validate
	 * @param string $field Unused by this rule
	 * @param array  $allFields Unused by this rule
	 *
	 * @return bool
	 *
	 * @since 2.0
	 */
	public function validate($value, $field = null, $allFields = null)
	{
		$regex = $this->getParameter();

		if ( ! is_string($value) or $regex === null)
		{
			return false;
		}

		return preg_match($regex, $value) == true;

It seems like you are loosely comparing preg_match($regex, $value) of type integer to the boolean true. If you are specifically checking for non-zero, consider using something more explicit like > 0 or !== 0 instead.

	}

	/**
	 * Sets the value to check against
	 *
	 * @param string $params If an array the first value will be used
	 *
	 * @return $this
	 *
	 * @since 2.0
	 */
	public function setParameter($params)
	{
		// Ensure we have only a single thing to match against
		if (is_array($params))
		{
			$params = array_shift($params);
		}

		return parent::setParameter($params);
	}

	/**
	 * Returns
	 *
	 * array(
	 * 		'pattern' => <Regex used for matching>
	 * );
	 *
	 * @return string[]
	 */
	public function getMessageParameters()
	{
		return array(
			'pattern' => $this->getParameter(),
		);
	}

}