HttpRequestFactory - Code Metrics - Inspection of "Adds in services for #31" - fuelphp/foundation - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — output_formatting ( c5a83b...d876bb )

by Emlyn

created 2017-05-25 08:13 UTC

HttpRequestFactory A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

65.22%

Importance

Changes

Metric	Value
wmc	9
c	0
b	0
f	0
lcom	1
cbo	2
dl	0
loc	44
ccs	15
cts	23
cp	0.6522
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	marshalProtocolVersion()	0	15	3
B	fromGlobals()	0	25	6

<?php
/**
 * @package    Fuel\Foundation
 * @version    2.0
 * @author     Fuel Development Team
 * @license    MIT License
 * @copyright  2010 - 2017 Fuel Development Team
 * @link       http://fuelphp.com
 */

namespace Fuel\Foundation\Request;

use UnexpectedValueException;
use Zend\Diactoros\ServerRequestFactory;

/**
 * Temporary request factory until fuel has a http message implementation
 *
 * @package Fuel\Foundation\Request
 */
class HttpRequestFactory extends ServerRequestFactory
{
	public static function fromGlobals(
		array $server = null,
		array $query = null,
		array $body = null,
		array $cookies = null,
		array $files = null
	) {
		$server  = static::normalizeServer($server ?: $_SERVER);
		$files   = static::normalizeFiles($files ?: $_FILES);
		$headers = static::marshalHeaders($server);

		return new Http(
			$server,
			$files,
			static::marshalUriFromServer($server, $headers),
			static::get('REQUEST_METHOD', $server, 'GET'),
			'php://input',
			$headers,
			$cookies ?: $_COOKIE,
			$query ?: $_GET,
			$body ?: $_POST,
			static::marshalProtocolVersion($server)
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
		);

	}

	private static function marshalProtocolVersion(array $server)

	{
		if (! isset($server['SERVER_PROTOCOL'])) {
			return '1.1';
		}

		if (! preg_match('#^(HTTP/)?(?P<version>[1-9]\d*(?:\.\d)?)$#', $server['SERVER_PROTOCOL'], $matches)) {
			throw new UnexpectedValueException(sprintf(
				'Unrecognized protocol version (%s)',
				$server['SERVER_PROTOCOL']
			));
		}

		return $matches['version'];
	}
}


1		<?php
2		/**
3		* @package Fuel\Foundation
4		* @version 2.0
5		* @author Fuel Development Team
6		* @license MIT License
7		* @copyright 2010 - 2017 Fuel Development Team
8		* @link http://fuelphp.com
9		*/
10
11		namespace Fuel\Foundation\Request;
12
13		use UnexpectedValueException;
14		use Zend\Diactoros\ServerRequestFactory;
15
16		/**
17		* Temporary request factory until fuel has a http message implementation
18		*
19		* @package Fuel\Foundation\Request
20		*/
21		class HttpRequestFactory extends ServerRequestFactory
22		{
23	10	public static function fromGlobals(
24		array $server = null,
25		array $query = null,
26		array $body = null,
27		array $cookies = null,
28		array $files = null
29		) {
30	10	$server = static::normalizeServer($server ?: $_SERVER);
31	10	$files = static::normalizeFiles($files ?: $_FILES);
32	10	$headers = static::marshalHeaders($server);
33
34	10	return new Http(
35		$server,
36		$files,
37	10	static::marshalUriFromServer($server, $headers),
38	10	static::get('REQUEST_METHOD', $server, 'GET'),
39	10	'php://input',
40		$headers,
41	10	$cookies ?: $_COOKIE,
42	10	$query ?: $_GET,
43	10	$body ?: $_POST,
44	10	static::marshalProtocolVersion($server)
		0 ignored issues – show Bug introduced 2016-05-10 15:44 UTC by Report Bug Copy Issue Report Since `marshalProtocolVersion()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `marshalProtocolVersion()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
45		);
46
47		}
48
49	10	private static function marshalProtocolVersion(array $server)
		0 ignored issues – show Bug introduced 2016-05-10 15:44 UTC by Report Bug Copy Issue Report Consider using a different method name as you override a private method of the parent class. Overwriting private methods is generally fine as long as you also use private visibility. It might still be preferable for understandability to use a different method name. Loading history...
50		{
51	10	if (! isset($server['SERVER_PROTOCOL'])) {
52	10	return '1.1';
53		}
54
55		if (! preg_match('#^(HTTP/)?(?P<version>[1-9]\d*(?:\.\d)?)$#', $server['SERVER_PROTOCOL'], $matches)) {
56		throw new UnexpectedValueException(sprintf(
57		'Unrecognized protocol version (%s)',
58		$server['SERVER_PROTOCOL']
59		));
60		}
61
62		return $matches['version'];
63		}
64		}
65

fuelphp / foundation

Push — output_formatting ( c5a83b...d876bb )

HttpRequestFactory A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

Duplication Side-by-Side

Filter issues like