ftrrtf /
FtrrtfRollbarBundle
| Conditions | 5 |
| Paths | 6 |
| Total Lines | 24 |
| Code Lines | 13 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 0 | Features | 0 |
| 1 | <?php |
||
| 16 | public function buildUserData($user) |
||
| 17 | { |
||
| 18 | if (is_string($user)) { |
||
| 19 | return array( |
||
| 20 | 'id' => $user, |
||
| 21 | ); |
||
| 22 | } |
||
| 23 | |||
| 24 | if (!($user instanceof UserInterface)) { |
||
| 25 | return array(); |
||
| 26 | } |
||
| 27 | |||
| 28 | $userData['id'] = method_exists($user, 'getId') |
||
|
1 ignored issue
–
show
|
|||
| 29 | ? $user->getId() |
||
|
1 ignored issue
–
show
|
|||
| 30 | : $user->getUsername(); |
||
| 31 | |||
| 32 | $userData['username'] = $user->getUsername(); |
||
| 33 | |||
| 34 | if (method_exists($user, 'getEmail')) { |
||
| 35 | $userData['email'] = $user->getEmail(); |
||
|
1 ignored issue
–
show
|
|||
| 36 | } |
||
| 37 | |||
| 38 | return $userData; |
||
| 39 | } |
||
| 40 | } |
||
| 41 |
Loading history...
Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.
Let’s take a look at an example:
As you can see in this example, the array
$myArrayis initialized the first time when the foreach loop is entered. You can also see that the value of thebarkey is only written conditionally; thus, its value might result from a previous iteration.This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.