ChecIOExtensionTest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	5	1
A	testGetChecIOJs()	0	6	1
A	testGetChecIOJsIgnoresIfFalsy()	0	6	1

<?php

class ChecIOExtensionTest extends SapphireTest

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    protected static $fixture_file = 'ChecIOShortcodeTest.yml';

    /**
     * @var Page
     */
    private $page;

    public function setUp()
    {
        parent::setUp();
        $this->page = $this->objFromFixture('SiteTree', 'test');

It seems like $this->objFromFixture('SiteTree', 'test') can also be of type object<DataObject>. However, the property $page is declared as type object<Page>. Maybe add an additional type check?

    }

    /**
     * Tests that a non-empty result is returned.
     */
    public function testGetChecIOJs()
    {
        $result = $this->page->getChecIOJs();
        $this->assertNotNull($result);

The method assertNotNull() does not seem to exist on object<ChecIOExtensionTest>.

        $this->assertContains('<script type="text/javascript', $result);
    }

    /**
     * Allow the JS to be disabled if desired
     */
    public function testGetChecIOJsIgnoresIfFalsy()
    {
        Config::inst()->update('ChecIOShortcode', 'third-party-js', '');
        $result = $this->page->getChecIOJs();
        $this->assertNotContains('<script type="text/javascript', $result);
    }
}