ChecIOShortcodeTest - Code Metrics - fspringveldt/silverstripe-checio-integration - Measure and Improve Code Quality continuously with Scrutinizer

ChecIOShortcodeTest A
last analyzed 2017-08-03 02:55 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	2
lcom	1
cbo	2
dl	0
loc	28
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	5	1
A	testBuyNowButton()	0	9	1

<?php

class ChecIOShortcodeTest extends FunctionalTest
namespace YourVendor;

class YourClass { }
{
    protected static $fixture_file = 'ChecIOShortcodeTest.yml';

    /**
     * @var Page
     */
    private $page;

    public function setUp()
    {
        parent::setUp();
        $this->page = $this->objFromFixture('SiteTree', 'test');
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }

    /**
     * Tests that the shortcode gets parsed
     */
    public function testBuyNowButton()
    {
        $text = $this->page->Content;
        $parsed = ShortcodeParser::get_active()->parse($text);
        $this->assertContains(
            '<a href="https://checkout.chec.io/1">Buy Now</a>',
            $parsed
        );
    }
}


1			<?php
2
3			class ChecIOShortcodeTest extends FunctionalTest
			0 ignored issues – show Coding Style Compatibility introduced 2017-07-31 02:42 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4			{
5			protected static $fixture_file = 'ChecIOShortcodeTest.yml';
6
7			/**
8			* @var Page
9			*/
10			private $page;
11
12			public function setUp()
13			{
14			parent::setUp();
15			$this->page = $this->objFromFixture('SiteTree', 'test');
			0 ignored issues – show Documentation Bug introduced 2017-07-31 02:42 UTC by Report Bug Copy Issue Report It seems like `$this->objFromFixture('SiteTree', 'test')` can also be of type `object<DataObject>`. However, the property `$page` is declared as type `object<Page>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
16			}
17
18			/**
19			* Tests that the shortcode gets parsed
20			*/
21			public function testBuyNowButton()
22			{
23			$text = $this->page->Content;
24			$parsed = ShortcodeParser::get_active()->parse($text);
25			$this->assertContains(
26			'<a href="https://checkout.chec.io/1">Buy Now</a>',
27			$parsed
28			);
29			}
30			}
31

fspringveldt / silverstripe-checio-integration

ChecIOShortcodeTest A last analyzed 2017-08-03 02:55 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like

ChecIOShortcodeTest A
last analyzed 2017-08-03 02:55 UTC