fsi-open / admin-security-bundle

Command/ChangePasswordCommand.php

<?php

/**
 * (c) FSi sp. z o.o. <info@fsi.pl>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace FSi\Bundle\AdminSecurityBundle\Command;

use Exception;
use FSi\Bundle\AdminSecurityBundle\Event\AdminSecurityEvents;
use FSi\Bundle\AdminSecurityBundle\Event\ChangePasswordEvent;
use FSi\Bundle\AdminSecurityBundle\Security\User\ChangeablePasswordInterface;
use FSi\Bundle\AdminSecurityBundle\Security\User\UserRepositoryInterface;
use InvalidArgumentException;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Helper\QuestionHelper;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Question\Question;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;

class ChangePasswordCommand extends Command
{
    /**
     * @var UserRepositoryInterface
     */
    private $userRepository;

    /**
     * @var EventDispatcherInterface
     */
    private $eventDispatcher;

    public function __construct(
        UserRepositoryInterface $userRepository,
        EventDispatcherInterface $eventDispatcher,
        $name = null
    ) {
        parent::__construct($name);

        $this->userRepository = $userRepository;
        $this->eventDispatcher = $eventDispatcher;
    }

    protected function configure(): void
    {
        $this
            ->setName('fsi:user:change-password')
            ->setDescription('Change password of a user.')
            ->setDefinition([
                new InputArgument('email', InputArgument::REQUIRED, 'The email'),
                new InputArgument('password', InputArgument::REQUIRED, 'The password'),
            ])
            ->setHelp(<<<EOT
The <info>fsi:user:change-password</info> command changes user's password:

  <info>php app/console fsi:user:change-password john@example.com</info>

This interactive shell will first ask you for a password.

You can alternatively specify the new password as a second argument:

  <info>php app/console fsi:user:change-password john@example.com mynewpassword</info>

EOT
            );
    }

    protected function execute(InputInterface $input, OutputInterface $output): void
    {
        $email = $input->getArgument('email');
        $password = $input->getArgument('password');

        $user = $this->userRepository->findUserByEmail($email);

It seems like $email can also be of type null and string[]; however, parameter $email of FSi\Bundle\AdminSecurityBundle\Security\User\UserRepositoryInterface::findUserByEmail() does only seem to accept string, maybe add an additional type check?

        if (false === $user instanceof ChangeablePasswordInterface) {
            throw new InvalidArgumentException(sprintf('User with email "%s" cannot be found', $email));

It seems like $email can also be of type string[]; however, parameter $args of sprintf() does only seem to accept string, maybe add an additional type check?

        }
        $user->setPlainPassword($password);

It seems like $password can also be of type null and string[]; however, parameter $password of FSi\Bundle\AdminSecurityBundle\Security\User\ChangeablePasswordInterface::setPlainPassword() does only seem to accept string, maybe add an additional type check?

        $this->eventDispatcher->dispatch(AdminSecurityEvents::CHANGE_PASSWORD, new ChangePasswordEvent($user));

The call to Symfony\Contracts\EventDispatcher\EventDispatcherInterface::dispatch() has too many arguments starting with new FSi\Bundle\AdminSecurityBundle\Event\ChangePasswordEvent($user).

FSi\Bundle\AdminSecurityBundle\Event\AdminSecurityEvents::CHANGE_PASSWORD of type string is incompatible with the type object expected by parameter $event of Symfony\Contracts\EventDispatcher\EventDispatcherInterface::dispatch().

        $output->writeln(sprintf('Changed password of user <comment>%s</comment>', $email));
    }

    protected function interact(InputInterface $input, OutputInterface $output): void
    {
        if (!$input->getArgument('email')) {
            $this->askEmail($input, $output);
        }

        if (!$input->getArgument('password')) {
            $this->askPassword($input, $output);
        }
    }

    private function askEmail(InputInterface $input, OutputInterface $output): void
    {
        $question = new Question('Please choose an email:');
        $question->setValidator(function (string $email): string {
            if (empty($email)) {
                throw new Exception('Email can not be empty');
            }

            return $email;
        });

        $email = $this->getQuestionHelper()->ask($input, $output, $question);
        $input->setArgument('email', $email);
    }

    private function askPassword(InputInterface $input, OutputInterface $output): void
    {
        $question = new Question('Please choose a password:');
        $question->setValidator(function (string $password): string {
            if (empty($password)) {
                throw new Exception('Password can not be empty');
            }

            return $password;
        });

        $password = $this->getQuestionHelper()->ask($input, $output, $question);
        $input->setArgument('password', $password);
    }

    private function getQuestionHelper(): QuestionHelper
    {
        return $this->getHelper('question');
    }
}