fsi-open / admin-security-bundle

FSiAdminSecurityBundle.php

<?php

/**
 * (c) FSi sp. z o.o. <info@fsi.pl>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace FSi\Bundle\AdminSecurityBundle;

use Doctrine\Bundle\DoctrineBundle\DependencyInjection\Compiler\DoctrineOrmMappingsPass;
use FSi\Bundle\AdminSecurityBundle\DependencyInjection\Compiler\FirewallMapCompilerPass;
use FSi\Bundle\AdminSecurityBundle\DependencyInjection\Compiler\ValidationCompilerPass;
use FSi\Bundle\AdminSecurityBundle\DependencyInjection\FSIAdminSecurityExtension;
use LogicException;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\HttpKernel\Bundle\Bundle;

class FSiAdminSecurityBundle extends Bundle
{
    public function build(ContainerBuilder $container)
    {
        parent::build($container);

        $container->addCompilerPass(new FirewallMapCompilerPass());
        $container->addCompilerPass(new ValidationCompilerPass());

        $doctrineConfigDir = realpath(__DIR__ . '/Resources/config/doctrine');

        $mappings = [
            $doctrineConfigDir . '/User' => 'FSi\Bundle\AdminSecurityBundle\Security\User',
            $doctrineConfigDir . '/Token' => 'FSi\Bundle\AdminSecurityBundle\Security\Token',
        ];

        $container->addCompilerPass(DoctrineOrmMappingsPass::createXmlMappingDriver($mappings));

        if ($container->hasExtension('fos_user')) {
            $mappings = [
                $doctrineConfigDir . '/FOS' => 'FSi\Bundle\AdminSecurityBundle\Security\FOS',
            ];

            $container->addCompilerPass(DoctrineOrmMappingsPass::createXmlMappingDriver($mappings));
        }
    }

    public function boot()
    {
        $userRepository = $this->container->get('admin_security.repository.user');
        $expectedRepositoryClass = '\FSi\Bundle\AdminSecurityBundle\Security\User\UserRepositoryInterface';
        if (!($userRepository instanceof $expectedRepositoryClass)) {
            throw new LogicException(sprintf(
                'Repository for class "\%s" does not implement the "\%s" interface!',
                get_class($userRepository),
                $expectedRepositoryClass
            ));
        }

        parent::boot();
    }

    /**
     * @return FSIAdminSecurityExtension
     */
    public function getContainerExtension()
    {
        if (null === $this->extension) {
            $this->extension = new FSIAdminSecurityExtension();
        }

        return $this->extension;

The expression $this->extension; of type Symfony\Component\DependencyInjection\Extension\ExtensionInterface|false adds false to the return on line 71 which is incompatible with the return type declared by the interface Symfony\Component\HttpKernel\Bundle\BundleInterface::getContainerExtension of type Symfony\Component\DependencyInjection\Extension\ExtensionInterface|null. It seems like you forgot to handle an error condition.

    }
}