Complex classes like User often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use User, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
14 | abstract class User implements UserInterface |
||
15 | { |
||
16 | /** |
||
17 | * @var int |
||
18 | */ |
||
19 | protected $id; |
||
20 | |||
21 | /** |
||
22 | * @var string |
||
23 | */ |
||
24 | protected $username; |
||
25 | |||
26 | /** |
||
27 | * @var string |
||
28 | */ |
||
29 | protected $email; |
||
30 | |||
31 | /** |
||
32 | * @var boolean |
||
33 | */ |
||
34 | protected $enabled; |
||
35 | |||
36 | /** |
||
37 | * @var boolean |
||
38 | */ |
||
39 | protected $enforcePasswordChange; |
||
40 | |||
41 | /** |
||
42 | * The salt to use for hashing |
||
43 | * |
||
44 | * @var string |
||
45 | */ |
||
46 | protected $salt; |
||
47 | |||
48 | /** |
||
49 | * Encrypted password. Must be persisted. |
||
50 | * |
||
51 | * @var string |
||
52 | */ |
||
53 | protected $password; |
||
54 | |||
55 | /** |
||
56 | * Plain password. Used for model validation. Must not be persisted. |
||
57 | * |
||
58 | * @var string |
||
59 | */ |
||
60 | protected $plainPassword; |
||
61 | |||
62 | /** |
||
63 | * @var \DateTime |
||
64 | */ |
||
65 | protected $lastLogin; |
||
66 | |||
67 | /** |
||
68 | * @var TokenInterface |
||
69 | */ |
||
70 | protected $activationToken; |
||
71 | |||
72 | /** |
||
73 | * @var TokenInterface |
||
74 | */ |
||
75 | protected $passwordResetToken; |
||
76 | |||
77 | /** |
||
78 | * @var boolean |
||
79 | */ |
||
80 | protected $locked; |
||
81 | |||
82 | /** |
||
83 | * @var boolean |
||
84 | */ |
||
85 | protected $expired; |
||
86 | |||
87 | /** |
||
88 | * @var \DateTime |
||
89 | */ |
||
90 | protected $expiresAt; |
||
91 | |||
92 | /** |
||
93 | * @var array |
||
94 | */ |
||
95 | protected $roles; |
||
96 | |||
97 | /** |
||
98 | * @var boolean |
||
99 | */ |
||
100 | protected $credentialsExpired; |
||
101 | |||
102 | /** |
||
103 | * @var \DateTime |
||
104 | */ |
||
105 | protected $credentialsExpireAt; |
||
106 | |||
107 | public function __construct() |
||
117 | |||
118 | /** |
||
119 | * Serializes the user. |
||
120 | * |
||
121 | * The serialized data have to contain the fields used by the equals method and the username. |
||
122 | * |
||
123 | * @return string |
||
124 | */ |
||
125 | public function serialize() |
||
138 | |||
139 | /** |
||
140 | * Unserializes the user. |
||
141 | * |
||
142 | * @param string $serialized |
||
143 | */ |
||
144 | public function unserialize($serialized) |
||
162 | |||
163 | /** |
||
164 | * Removes sensitive data from the user. |
||
165 | */ |
||
166 | public function eraseCredentials() |
||
170 | |||
171 | /** |
||
172 | * Returns the user unique id. |
||
173 | * |
||
174 | * @return mixed |
||
175 | */ |
||
176 | public function getId() |
||
180 | |||
181 | public function getUsername() |
||
185 | |||
186 | public function getSalt() |
||
190 | |||
191 | public function getEmail() |
||
195 | |||
196 | /** |
||
197 | * Gets the encrypted password. |
||
198 | * |
||
199 | * @return string |
||
200 | */ |
||
201 | public function getPassword() |
||
205 | |||
206 | public function getPlainPassword() |
||
210 | |||
211 | /** |
||
212 | * Gets the last login time. |
||
213 | * |
||
214 | * @return \DateTime |
||
215 | */ |
||
216 | public function getLastLogin() |
||
220 | |||
221 | /** |
||
222 | * @return TokenInterface |
||
223 | */ |
||
224 | public function getActivationToken() |
||
228 | |||
229 | /** |
||
230 | * @param TokenInterface $activationToken |
||
231 | */ |
||
232 | public function setActivationToken(TokenInterface $activationToken) |
||
236 | |||
237 | public function removeActivationToken() |
||
241 | |||
242 | /** |
||
243 | * @return TokenInterface |
||
244 | */ |
||
245 | public function getPasswordResetToken() |
||
249 | |||
250 | /** |
||
251 | * @param TokenInterface $passwordResetToken |
||
252 | */ |
||
253 | public function setPasswordResetToken(TokenInterface $passwordResetToken) |
||
257 | |||
258 | public function removePasswordResetToken() |
||
262 | |||
263 | /** |
||
264 | * Returns the user roles |
||
265 | * |
||
266 | * @return array The roles |
||
267 | */ |
||
268 | public function getRoles() |
||
274 | |||
275 | public function isAccountNonExpired() |
||
287 | |||
288 | public function isAccountNonLocked() |
||
292 | |||
293 | public function isCredentialsNonExpired() |
||
305 | |||
306 | public function isCredentialsExpired() |
||
310 | |||
311 | public function isEnabled() |
||
315 | |||
316 | public function isExpired() |
||
320 | |||
321 | public function isLocked() |
||
325 | |||
326 | public function addRole($role) |
||
336 | |||
337 | public function removeRole($role) |
||
346 | |||
347 | public function setUsername($username) |
||
353 | |||
354 | /** |
||
355 | * @param \DateTime $date |
||
356 | * |
||
357 | * @return User |
||
358 | */ |
||
359 | public function setCredentialsExpireAt(\DateTime $date) |
||
365 | |||
366 | /** |
||
367 | * @param boolean $boolean |
||
368 | * |
||
369 | * @return User |
||
370 | */ |
||
371 | public function setCredentialsExpired($boolean) |
||
377 | |||
378 | public function setEmail($email) |
||
384 | |||
385 | public function setEnabled($boolean) |
||
391 | |||
392 | /** |
||
393 | * Sets this user to expired. |
||
394 | * |
||
395 | * @param Boolean $boolean |
||
396 | * |
||
397 | * @return User |
||
398 | */ |
||
399 | public function setExpired($boolean) |
||
405 | |||
406 | /** |
||
407 | * @param \DateTime $date |
||
408 | * |
||
409 | * @return User |
||
410 | */ |
||
411 | public function setExpiresAt(\DateTime $date) |
||
417 | |||
418 | public function setPassword($password) |
||
424 | |||
425 | public function setPlainPassword($password) |
||
431 | |||
432 | public function setLastLogin(\DateTime $time) |
||
438 | |||
439 | public function setLocked($boolean) |
||
445 | |||
446 | public function isForcedToChangePassword() |
||
450 | |||
451 | public function enforcePasswordChange($enforcePasswordChange) |
||
455 | |||
456 | public function __toString() |
||
460 | } |
||
461 |