SubscriberForm::getSuccessRoute() - Code Metrics - Inspection of "Initial Sf3 support" - fsi-open/admin-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#244)

by Łukasz

created 2017-02-10 16:01 UTC

SubscriberForm::getSuccessRoute() A

↳ Parent: SubscriberForm

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php

/**
 * (c) FSi sp. z o.o. <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace FSi\FixturesBundle\Admin;

use FSi\Bundle\AdminBundle\Doctrine\Admin\FormElement;
use FSi\Bundle\AdminBundle\Form\TypeSolver;
use Symfony\Component\Form\FormFactoryInterface;

class SubscriberForm extends FormElement
{
    public function getClassName()
    {
        return 'FSi\FixturesBundle\Entity\Subscriber';
    }

    public function getId()
    {
        return 'subscriber_form';
    }

    public function getName()
    {
        return 'admin.subscriber.name';
    }

    public function getSuccessRoute()
    {
        return 'fsi_admin_list';
    }

    public function getSuccessRouteParameters()
    {
        return array('element' => 'subscriber');
    }

    protected function initForm(FormFactoryInterface $factory, $data = null)
    {
        $builder = $factory->createNamedBuilder(
            'subscriber',
            TypeSolver::getFormType('Symfony\Component\Form\Extension\Core\Type\FormType', 'form'),

            $data,
            array(
                'data_class' => $this->getClassName()
            )
        );

        $builder->add(
            'email',
            TypeSolver::getFormType('Symfony\Component\Form\Extension\Core\Type\EmailType', 'email'),

            array(
                'label' => 'admin.subscriber.list.email',
            )
        );

        $builder->add(
            'created_at',
            TypeSolver::getFormType('Symfony\Component\Form\Extension\Core\Type\DateType', 'date'),

            array(
                'label' => 'admin.subscriber.list.created_at',
                'widget' => 'single_text'
            )
        );

        $builder->add(
            'active',
            TypeSolver::getFormType('Symfony\Component\Form\Extension\Core\Type\CheckboxType', 'checkbox'),

            array(
                'label' => 'admin.subscriber.list.active',
            )
        );

        return $builder->getForm();
    }
}


1			<?php
2
3			/**
4			* (c) FSi sp. z o.o. <[email protected]>
5			*
6			* For the full copyright and license information, please view the LICENSE
7			* file that was distributed with this source code.
8			*/
9
10			namespace FSi\FixturesBundle\Admin;
11
12			use FSi\Bundle\AdminBundle\Doctrine\Admin\FormElement;
13			use FSi\Bundle\AdminBundle\Form\TypeSolver;
14			use Symfony\Component\Form\FormFactoryInterface;
15
16			class SubscriberForm extends FormElement
17			{
18			public function getClassName()
19			{
20			return 'FSi\FixturesBundle\Entity\Subscriber';
21			}
22
23			public function getId()
24			{
25			return 'subscriber_form';
26			}
27
28			public function getName()
29			{
30			return 'admin.subscriber.name';
31			}
32
33			public function getSuccessRoute()
34			{
35			return 'fsi_admin_list';
36			}
37
38			public function getSuccessRouteParameters()
39			{
40			return array('element' => 'subscriber');
41			}
42
43			protected function initForm(FormFactoryInterface $factory, $data = null)
44			{
45			$builder = $factory->createNamedBuilder(
46			'subscriber',
47			TypeSolver::getFormType('Symfony\Component\Form\Extension\Core\Type\FormType', 'form'),
			0 ignored issues – show Bug introduced 2017-01-17 18:00 UTC by Report Bug Copy Issue Report It seems like `\FSi\Bundle\AdminBundle\...ype\\FormType', 'form')` targeting `FSi\Bundle\AdminBundle\F...peSolver::getFormType()` can also be of type `object<Symfony\Component\Form\FormTypeInterface>`; however, `Symfony\Component\Form\F...e::createNamedBuilder()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
48			$data,
49			array(
50			'data_class' => $this->getClassName()
51			)
52			);
53
54			$builder->add(
55			'email',
56			TypeSolver::getFormType('Symfony\Component\Form\Extension\Core\Type\EmailType', 'email'),
			0 ignored issues – show Bug introduced 2017-01-17 18:00 UTC by Report Bug Copy Issue Report It seems like `\FSi\Bundle\AdminBundle\...e\\EmailType', 'email')` targeting `FSi\Bundle\AdminBundle\F...peSolver::getFormType()` can also be of type `object<Symfony\Component\Form\FormTypeInterface>`; however, `Symfony\Component\Form\FormBuilderInterface::add()` does only seem to accept `string\|null`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
57			array(
58			'label' => 'admin.subscriber.list.email',
59			)
60			);
61
62			$builder->add(
63			'created_at',
64			TypeSolver::getFormType('Symfony\Component\Form\Extension\Core\Type\DateType', 'date'),
			0 ignored issues – show Bug introduced 2017-01-17 18:00 UTC by Report Bug Copy Issue Report It seems like `\FSi\Bundle\AdminBundle\...ype\\DateType', 'date')` targeting `FSi\Bundle\AdminBundle\F...peSolver::getFormType()` can also be of type `object<Symfony\Component\Form\FormTypeInterface>`; however, `Symfony\Component\Form\FormBuilderInterface::add()` does only seem to accept `string\|null`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
65			array(
66			'label' => 'admin.subscriber.list.created_at',
67			'widget' => 'single_text'
68			)
69			);
70
71			$builder->add(
72			'active',
73			TypeSolver::getFormType('Symfony\Component\Form\Extension\Core\Type\CheckboxType', 'checkbox'),
			0 ignored issues – show Bug introduced 2017-01-17 18:00 UTC by Report Bug Copy Issue Report It seems like `\FSi\Bundle\AdminBundle\...ckboxType', 'checkbox')` targeting `FSi\Bundle\AdminBundle\F...peSolver::getFormType()` can also be of type `object<Symfony\Component\Form\FormTypeInterface>`; however, `Symfony\Component\Form\FormBuilderInterface::add()` does only seem to accept `string\|null`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
74			array(
75			'label' => 'admin.subscriber.list.active',
76			)
77			);
78
79			return $builder->getForm();
80			}
81			}
82

fsi-open / admin-bundle

Pull Request — master (#244)

SubscriberForm::getSuccessRoute() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like