Issues in ElementImpl.php - New Issues - Inspection of "Utilize php 7.1 features wherever possible" - fsi-open/admin-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#311)

by Łukasz

created 2017-09-14 08:23 UTC

Doctrine/Admin/ElementImpl.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

/**
 * (c) FSi sp. z o.o. <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace FSi\Bundle\AdminBundle\Doctrine\Admin;

use Doctrine\Common\Persistence\ManagerRegistry;
use Doctrine\Common\Persistence\ObjectManager;
use Doctrine\Common\Persistence\ObjectRepository;
use FSi\Bundle\AdminBundle\Exception\RuntimeException;

trait ElementImpl
{
    /**
     * @var ManagerRegistry
     */
    protected $registry;

    public function setManagerRegistry(ManagerRegistry $registry): void
    {
        $this->registry = $registry;
    }

    public function getObjectManager(): ObjectManager
    {
        $om = $this->registry->getManagerForClass($this->getClassName());

        if (null === $om) {
            throw new RuntimeException(sprintf(
                'Registry manager does\'t have manager for class "%s".',
                $this->getClassName()
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ));
        }

        return $om;
    }

    public function getRepository(): ObjectRepository
    {
        return $this->getObjectManager()->getRepository($this->getClassName());
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/**
6			* (c) FSi sp. z o.o. <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace FSi\Bundle\AdminBundle\Doctrine\Admin;
13
14			use Doctrine\Common\Persistence\ManagerRegistry;
15			use Doctrine\Common\Persistence\ObjectManager;
16			use Doctrine\Common\Persistence\ObjectRepository;
17			use FSi\Bundle\AdminBundle\Exception\RuntimeException;
18
19			trait ElementImpl
20			{
21			/**
22			* @var ManagerRegistry
23			*/
24			protected $registry;
25
26			public function setManagerRegistry(ManagerRegistry $registry): void
27			{
28			$this->registry = $registry;
29			}
30
31			public function getObjectManager(): ObjectManager
32			{
33			$om = $this->registry->getManagerForClass($this->getClassName());
34
35			if (null === $om) {
36			throw new RuntimeException(sprintf(
37			'Registry manager does\'t have manager for class "%s".',
38			$this->getClassName()
			0 ignored issues – show Bug introduced 2017-09-13 18:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `getClassName()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
39			));
40			}
41
42			return $om;
43			}
44
45			public function getRepository(): ObjectRepository
46			{
47			return $this->getObjectManager()->getRepository($this->getClassName());
48			}
49			}
50

fsi-open / admin-bundle

Pull Request — master (#311)

Doctrine/Admin/ElementImpl.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like