1 | <?php |
||
20 | class FormValidRequestHandler extends AbstractFormValidRequestHandler |
||
21 | { |
||
22 | /** |
||
23 | * @param \FSi\Bundle\AdminBundle\Event\FormEvent $event |
||
24 | * @param \Symfony\Component\HttpFoundation\Request $request |
||
25 | */ |
||
26 | protected function action(FormEvent $event, Request $request) |
||
30 | |||
31 | /** |
||
32 | * @return string |
||
33 | */ |
||
34 | protected function getPreSaveEventName() |
||
38 | |||
39 | /** |
||
40 | * @return string |
||
41 | */ |
||
42 | protected function getPostSaveEventName() |
||
46 | |||
47 | /** |
||
48 | * @param \FSi\Bundle\AdminBundle\Event\AdminEvent $event |
||
49 | * @param \Symfony\Component\HttpFoundation\Request $request |
||
50 | * @return null|\Symfony\Component\HttpFoundation\Response |
||
51 | */ |
||
52 | public function handleRequest(AdminEvent $event, Request $request) |
||
64 | |||
65 | /** |
||
66 | * @param \FSi\Bundle\AdminBundle\Event\FormEvent $event |
||
67 | * @param \Symfony\Component\HttpFoundation\Request $request |
||
68 | * @return bool |
||
69 | */ |
||
70 | protected function isValidPostRequest(FormEvent $event, Request $request) |
||
85 | |||
86 | /** |
||
87 | * @param \FSi\Bundle\AdminBundle\Event\FormEvent $event |
||
88 | * @param \Symfony\Component\HttpFoundation\Request $request |
||
89 | * @return \Symfony\Component\HttpFoundation\RedirectResponse |
||
90 | */ |
||
91 | protected function getRedirectResponse(FormEvent $event, Request $request) |
||
99 | } |
||
100 |
Let’s take a look at an example:
In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.
Available Fixes
Change the type-hint for the parameter:
Add an additional type-check:
Add the method to the interface: