1 | <?php |
||
19 | class FormValidRequestHandler extends AbstractFormValidRequestHandler |
||
20 | { |
||
21 | /** |
||
22 | * @param \FSi\Bundle\AdminBundle\Event\FormEvent $event |
||
23 | * @param \Symfony\Component\HttpFoundation\Request $request |
||
24 | */ |
||
25 | protected function action(FormEvent $event, Request $request) |
||
29 | |||
30 | /** |
||
31 | * @return string |
||
32 | */ |
||
33 | protected function getPreSaveEventName() |
||
37 | |||
38 | /** |
||
39 | * @return string |
||
40 | */ |
||
41 | protected function getPostSaveEventName() |
||
45 | |||
46 | /** |
||
47 | * @param \FSi\Bundle\AdminBundle\Event\AdminEvent $event |
||
48 | * @param \Symfony\Component\HttpFoundation\Request $request |
||
49 | * @return null|\Symfony\Component\HttpFoundation\Response |
||
50 | */ |
||
51 | public function handleRequest(AdminEvent $event, Request $request) |
||
63 | |||
64 | /** |
||
65 | * @param \FSi\Bundle\AdminBundle\Event\FormEvent $event |
||
66 | * @param \Symfony\Component\HttpFoundation\Request $request |
||
67 | * @return \Symfony\Component\HttpFoundation\RedirectResponse |
||
68 | */ |
||
69 | protected function getRedirectResponse(FormEvent $event, Request $request) |
||
77 | } |
||
78 |
Let’s take a look at an example:
In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.
Available Fixes
Change the type-hint for the parameter:
Add an additional type-check:
Add the method to the interface: