Issues in Session.php (master) - Issues in master - frqnck/apix - Measure and Improve Code Quality continuously with Scrutinizer

Issues (320)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/php/Apix/Session.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 *
 * This file is part of the Apix Project.
 *
 * (c) Franck Cassedanne <franck at ouarz.net>
 *
 * @license     http://opensource.org/licenses/BSD-3-Clause  New BSD License
 *
 */

namespace Apix;

class Session
{

    /**
     * Holds the session's username.
     * @var string
     */
    protected $username;

    /**
     * Holds this user's group.
     * @var string
     */
    protected $group;

    /**
     * Holds the user's trusted IPs.
     * @var array
     */
    protected $ips = null;

    /**
     * Holds some user's arbitrary data.
     * @var array
     */
    protected $data = array();

    /**
     * Constructor will set the session for the given username.
     *
     * @param string      $username
     * @param string|null $group
     */
    public function __construct($username, $group = null)
    {
        $this->username = $username;
        $this->group = $group;

        // session_start();
    }

    /**
     * Returns the username.
     *
     * @return string
     */
    public function getUsername()
    {
        return $this->username;
    }

    /**
     * Returns the user's group.
     *
     * @return string
     */
    public function getGroup()
    {
        return $this->group;
    }

    /**
     * Sets the user's group.
     *
     * @param  string $group
     * @return void
     */
    public function setGroup($group)
    {
        $this->group = $group;
    }

    /**
     * Returns the trusted IPs.
     *
     * @return array
     */
    public function getTrustedIps()
    {
        return $this->ips;
    }

    /**
     * Sets the trusted IPs.
     *
     * @param  array $ips
     * @return void
     */
    public function setTrustedIps(array $ips=null)
    {
        $this->ips = $ips;
function aContainsB(array $needle = null, array  $haystack) {
    if (!$needle) {
        return false;
    }

    return array_intersect($haystack, $needle) == $haystack;
}
    }

    /**
     * Check if the specified user data is set.
     *
     * @param  string  $group
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return boolean
     */
    public function hasTrustedIps()
    {
        return null !== $this->ips;
    }

    /**
     * Adds arbitrary session data.
     *
     * @param  string $group
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return void
     */
    public function addData($key, $value)
    {
        $this->data[$key] = $value;
    }

    /**
     * Checks wether the specified key is set in the session dataset.
     *
     * @param  string  $group
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return boolean
     */
    public function hasData($key)
    {
        return isset($this->data[$key]);
    }

    /**
     * Returns the specified data -- or the whole dataset if null.
     *
     * @param  string     $key
     * @return mixed|null
     */
    public function getData($key=null)
    {
        if(null === $key) return $this->data;

        return isset($this->data[$key]) ? $this->data[$key] : null;
    }

}


1			<?php
2
3			/**
4			*
5			* This file is part of the Apix Project.
6			*
7			* (c) Franck Cassedanne <franck at ouarz.net>
8			*
9			* @license http://opensource.org/licenses/BSD-3-Clause New BSD License
10			*
11			*/
12
13			namespace Apix;
14
15			class Session
16			{
17
18			/**
19			* Holds the session's username.
20			* @var string
21			*/
22			protected $username;
23
24			/**
25			* Holds this user's group.
26			* @var string
27			*/
28			protected $group;
29
30			/**
31			* Holds the user's trusted IPs.
32			* @var array
33			*/
34			protected $ips = null;
35
36			/**
37			* Holds some user's arbitrary data.
38			* @var array
39			*/
40			protected $data = array();
41
42			/**
43			* Constructor will set the session for the given username.
44			*
45			* @param string $username
46			* @param string\|null $group
47			*/
48			public function __construct($username, $group = null)
49			{
50			$this->username = $username;
51			$this->group = $group;
52
53			// session_start();
54			}
55
56			/**
57			* Returns the username.
58			*
59			* @return string
60			*/
61			public function getUsername()
62			{
63			return $this->username;
64			}
65
66			/**
67			* Returns the user's group.
68			*
69			* @return string
70			*/
71			public function getGroup()
72			{
73			return $this->group;
74			}
75
76			/**
77			* Sets the user's group.
78			*
79			* @param string $group
80			* @return void
81			*/
82			public function setGroup($group)
83			{
84			$this->group = $group;
85			}
86
87			/**
88			* Returns the trusted IPs.
89			*
90			* @return array
91			*/
92			public function getTrustedIps()
93			{
94			return $this->ips;
95			}
96
97			/**
98			* Sets the trusted IPs.
99			*
100			* @param array $ips
101			* @return void
102			*/
103			public function setTrustedIps(array $ips=null)
104			{
105			$this->ips = $ips;
			0 ignored issues – show Documentation Bug introduced 2016-04-08 09:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$ips` can be `null`. However, the property `$ips` is declared as `array`. Maybe change the type of the property to `array\|null` or add a type check? Our type inference engine has found an assignment of a scalar value (like a string, an integer or null) to a property which is an array. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property. To type hint that a parameter can be either an array or null, you can set a type hint of array and a default value of null. The PHP interpreter will then accept both an array or null for that parameter. function aContainsB(array $needle = null, array $haystack) { if (!$needle) { return false; } return array_intersect($haystack, $needle) == $haystack; } The function can be called with either null or an array for the parameter `$needle` but will only accept an array as `$haystack`. Loading history...
106			}
107
108			/**
109			* Check if the specified user data is set.
110			*
111			* @param string $group
			0 ignored issues – show Bug introduced 2016-04-08 09:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$group`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
112			* @return boolean
113			*/
114			public function hasTrustedIps()
115			{
116			return null !== $this->ips;
117			}
118
119			/**
120			* Adds arbitrary session data.
121			*
122			* @param string $group
			0 ignored issues – show Bug introduced 2016-04-08 09:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$group`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
123			* @return void
124			*/
125			public function addData($key, $value)
126			{
127			$this->data[$key] = $value;
128			}
129
130			/**
131			* Checks wether the specified key is set in the session dataset.
132			*
133			* @param string $group
			0 ignored issues – show Bug introduced 2016-04-08 09:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$group`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
134			* @return boolean
135			*/
136			public function hasData($key)
137			{
138			return isset($this->data[$key]);
139			}
140
141			/**
142			* Returns the specified data -- or the whole dataset if null.
143			*
144			* @param string $key
145			* @return mixed\|null
146			*/
147			public function getData($key=null)
148			{
149			if(null === $key) return $this->data;
150
151			return isset($this->data[$key]) ? $this->data[$key] : null;
152			}
153
154			}
155

frqnck / apix

Issues (320)

Security Analysis not enabled

src/php/Apix/Session.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like