frqnck / apix

src/php/Apix/HttpRequest.php

<?php

/**
 *
 * This file is part of the Apix Project.
 *
 * (c) Franck Cassedanne <franck at ouarz.net>
 *
 * @license     http://opensource.org/licenses/BSD-3-Clause  New BSD License
 *
 */

namespace Apix;

use Apix\Request,
    Apix\Input\InputInterface,
    Apix\Input\Xml,
    Apix\Input\Json;

class HttpRequest extends Request
{
    /**
     * List of supported input formats.
     * @var array
     */
    protected $formats = array('post', 'json', 'xml');

    /**
     * Returns the format from an HTTP context.
     *
     * @param  string $context The context to extract the format from.
     * @return string The extracted format.
     */
    public static function getFormat($context)
    {
        switch (true) {

It seems like you are loosely comparing strstr($context, '/html') of type string to the boolean true. If you are specifically checking for a non-empty string, consider using the more explicit !== '' instead.

It seems like you are loosely comparing strstr($context, '/json') of type string to the boolean true. If you are specifically checking for a non-empty string, consider using the more explicit !== '' instead.

            // text/html
            case (strstr($context, '/html')):
                return 'html';

            // application/json
            case (strstr($context, '/json')):
                return 'json';

            // text/xml, application/xml
            case (strstr($context, '/xml')
                && (!strstr($context, 'html'))):
                return 'xml';

            default:
                return null;
        }
    }

    /**
     * Returns the format from an HTTP Accept.
     *
     * @return string The output format
     */
    public function getAcceptFormat()
    {
        if ($this->hasHeader('HTTP_ACCEPT')) {
            $accept = $this->getHeader('HTTP_ACCEPT');

            if (!$format = self::getFormat($accept)) {
                // 'application/javascript'
                $format = strstr($accept, '/javascript') ? 'jsonp' : null;
            }
        }

        return isset($format) ? $format : false;
    }

    /**
     * Get & parse the request body-data.
     *
     * @param  boolean $assoc Wether to convert objects to associative arrays or not.
     * @return array
     * @link http://www.w3.org/TR/html401/interact/forms.html#h-17.13.4
     * @link http://www.w3.org/TR/html401/references.html#ref-RFC2388
     */
    public function getBodyData($assoc=true)
    {
        if ($this->hasBody() && $this->hasHeader('CONTENT_TYPE')) {
            $ctx = $this->getHeader('CONTENT_TYPE');

            if (
                in_array('post', $this->formats)
                // application/x-www-form-urlencoded
                && strstr($ctx, '/x-www-form-urlencoded')
                // TODO: shall we do multipart/form-data too?
            ) {
                // handles by PHP already. No need to parse the body.
                return $this->getParams();
            } elseif ($format = self::getFormat($ctx)) {
                if (in_array(strtolower($format), $this->formats)) {
                    $class = __NAMESPACE__ . '\Input\\' . ucfirst($format);
                    $input = new $class();

                    return $input->decode($this->getBody(), $assoc);
                    #$this->setParams($r); // TODO: maybe set as request params?

75% of this comment could be valid code. Did you maybe forget this after debugging?

                }
            }

            return null;
        }
    }

    /**
     * Sets the input formats.
     *
     * @return void
     */
    public function setFormats(array $formats)
    {
        $this->formats = $formats;
    }

}