Apix\Plugin\Auth::update()

Complexity

Conditions	13
Paths	8

Size

Total Lines	89
Code Lines	38

Duplication

Lines	15
Ratio	16.85 %

Code Coverage

Tests	0
CRAP Score	182

Importance

Changes

0

<?php
    public function update(\SplSubject $entity)

update uses the super-global variable $_SERVER which is generally not recommended.

    {
        $this->entity = $entity;

$entity is of type object<SplSubject>, but the property $entity was declared to be of type object<Apix\Entity>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

        $groups = $this->getSubTagValues('groups');
        $users = $this->getSubTagValues('users');

        // skip auth if groups and users are both null
        // or if the group is public.
        if(
            null === $users
            && null === $groups
            || null !== $groups
            && in_array($this->options['public_group'], $groups)
        ) {
            return null;
        }

        $logger = Service::get('logger');

        // authenticate
        if ( !$this->adapter->authenticate() ) {

            // $logger->info(
            //     'Login failed for "{username}"',
            //     array('username' => $this->adapter->getUsername())

67% of this comment could be valid code. Did you maybe forget this after debugging?

            // );

            $this->adapter->send();

            // TODO: eventually in Auth...
            // $response = Service::get('response');

50% of this comment could be valid code. Did you maybe forget this after debugging?

            // $response->setHeaders($headers);

75% of this comment could be valid code. Did you maybe forget this after debugging?

            // $response->send();

72% of this comment could be valid code. Did you maybe forget this after debugging?

            throw new Exception('Authentication required', 401);
        }

        // TODO: get the Session object.
        if (Service::has('session')) {
            $session = Service::get('session');

            $context = array('user' => $session->getUsername());

            // check the username is in the authorised list.
            if (null !== $users && !in_array($context['user'], $users)) {

This code seems to be duplicated across your project.

                $logger->notice('Auth: User unauthorised [{user}]', $context);

                throw new Exception('Access unauthorised', 401);
            }

            // check user group
            $context['group'] = $session->getGroup();
            if (null !== $groups && !in_array($context['group'], $groups) ) {

This code seems to be duplicated across your project.

                $logger->notice(
                    'Auth: Sessions\'s group unauthorised [{user}/{group}]".',
                    $context
                );

                throw new Exception('Access unauthorised.', 401);
            }

            // check for (required) trusted user IPs
            if ($session->hasTrustedIps()) {
                $context['ip'] = Service::get('response')->getRequest()->getIp();
                if (!$this->isTrustedIp($context['ip'], $session->getTrustedIps())) {

                    $logger->notice(
                        'Auth: Session\'s IP not trusted [{user}/{group}/{ip}].',
                        $context
                    );

                    throw new Exception('Session\'s IP not trusted', 401);
                }
            }

            // TODO: set X_REMOTE_USER or X_AUTH_USER
            $_SERVER['X_AUTH_USER'] = $context['user'];

            $logger->info(
                'Auth: User logged in [{user}/{group}/{ip}]',
                $context
            );
        }

        return true;
    }