Main::run() - Code Metrics - frqnck/apix - Measure and Improve Code Quality continuously with Scrutinizer

Main::run() F
last analyzed 2017-05-17 20:31 UTC

↳ Parent: Main

Complexity

Conditions	31
Paths	258

Size

Total Lines	138
Code Lines	98

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	992

Importance

Changes

Metric	Value
dl	0
loc	138
ccs	0
cts	0
cp	0
rs	3.4536
c	0
b	0
f	0
cc	31
eloc	98
nc	258
nop	0
crap	992

How to fix Long Method Complexity

<?php

/**
 *
 * This file is part of the Apix Project.
 *
 * (c) Franck Cassedanne <franck at ouarz.net>
 *
 * @license     http://opensource.org/licenses/BSD-3-Clause  New BSD License
 *
 */

namespace Apix\Console;

use Apix\Console,
    Apix\Server,
    Apix\Input;

/**
 * Main Console class.
 *
 * @codeCoverageIgnore
 */
class Main extends Console
{

    protected $version;
    protected $version_program;

    protected $src;
    protected $src_file = 'apix.phar';
    protected $src_url;

    protected $phar_name = null;

    public function __construct(array $options = null)
    {
        $this->src_url = 'http://api.ouarz.net/v1/%s/%s/in/%s';

        #$this->src = realpath(__DIR__ . '/../../../../../');

        $this->src = realpath(__DIR__ . '/../../../../');

        $this->version = Server::VERSION;
        $this->version_program =
            sprintf('Apix Server %s by Franck Cassedanne.', $this->version);

        parent::__construct($options);
    }

    public function setPharName($name)
    {
        $this->phar_name = $name;
        $this->src = $name;
    }

    public function setSrcFile($name)
    {
        $this->src_file = $name;
    }

    public function run()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $args = $this->getArgs();
        $args[0] = 'php ' . $args[0];

        $cmd = empty($args[1])
                ? '--help'
                : $args[1];

        $this->out($this->version_program . PHP_EOL .PHP_EOL);

        switch ($cmd):
            case '-r': case '--readme':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                $this->out('README' . PHP_EOL . PHP_EOL, 'bold', 'underline');
                $this->out(
                    file_get_contents($this->src . '/README.md')
                );
                $this->out();
            break;

            case '--version':
                exit(0);

            break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}

            case '--extractdist': case '-e':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                $src = $this->src . '/src/data/distribution/';
                $dest = $_SERVER['PWD'];
                try {
                    $it = new \DirectoryIterator($src);
                    $this->out("Latest distribution files: " . PHP_EOL, 'green');

                    foreach ($it as $file) {
                        if ($file->isFile()) {
                            $this->out(" --> " . $file . PHP_EOL, "red");
                            file_put_contents(
                                $dest . '/' . $file,
                                file_get_contents($src . '/' .$file)
                            );
                        }
                    }
                } catch (\Exception $e) {
                    $this->outputError($e);
                }
                $this->out(PHP_EOL . "have been copied into:" . PHP_EOL, 'green');
                $this->out(" --> " . $dest . PHP_EOL .PHP_EOL, 'red');
                $this->out("Manually rename each files from '*.dist.php' to '*.php' to use them." . PHP_EOL);
                $this->out("e.g." . PHP_EOL . "cp -i config.dist.php projectname-config.php" . PHP_EOL, 'blue');
            break;

            case '-c': case '--check':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

                try {
                    $url = sprintf($this->src_url, 'version', $this->src_file, $this->version);

                    if ($this->verbose) {
                        $this->outRegex("Contacting...\n<brown>${url}</brown>\n\n");
                    }
                    $response = trim($this->getContents($url));

                    $input = new Input\Json();
                    $r = $input->decode($response, true);
                    if ($this->verbose > 2) {
                        print_r($r);
                    }

                    $latest = $r['apix']['version'][$this->src_file]['latest'];
                    if (empty($latest)) {
                        throw new \Exception("Something, somewhere failed!");
                    }

                    if ( version_compare($this->version, $latest, '>=') != 1) {
                        $this->out(sprintf("A newer version is available (%s).", $latest));
                        $this->outRegex(sprintf("\nTo update, run: <brown>%s --selfupdate</brown>\n",  $args[0]));
                    } else {
                        $this->out("You are using the latest version.");
                    }
                } catch (\Exception $e) {
                    $this->outputError($e);
                }
            break;

            case '--selfupdate':
                $url = sprintf($this->src_url, 'download', $this->src_file, $this->version);
                $dest = $_SERVER['argv'][0];

                if ($this->verbose > 2) {
                    $this->out(' --> ' . $dest);
                    $this->out();
                }

                $this->retrieveUpdate($url, $dest);
            break;

            case '-s': case '--syscheck':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                $syscheck = new SystemCheck();
                $syscheck->setArgs(array('--all', '--no-credits'));
                $syscheck->run();
                break;

            case '--license':
                $this->out(file_get_contents($this->src .'/LICENSE.txt'));
            break;

            case '-i': case '--info':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                phpinfo();
            break;

            case '-h': case '--help':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                $this->help();
            break;

            case '-t': case '--tests':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
                $cmd = 'phpunit';
                if ($this->verbose) {
                    $cmd .= ' --verbose';
                }
                if ($this->verbose > 2) {
                    $cmd .= ' --debug';
                }
                if (false == $this->no_colors) {
                    $cmd .= ' --colors';
                }
                $cmd .= ' --bootstrap src/tests/unit-tests/pharstrap.php';
                $cmd .= ' -c src/tests/unit-tests/pharunit.xml';
                system($cmd);
            break;

            default:
                $this->out('Error: ', $args[1], 'bold', 'red');
                $this->out(sprintf('unknown option/command "%s".' . PHP_EOL, $args[1]), 'red');
                $this->out(sprintf('You should try "%s --help".', $args[0]), 'green');

        endswitch;

        $this->out();

        exit(0);

    }

    public function help()

    {
        $args = $this->getArgs();
        $args[0] = 'php ' . $args[0];

        $this->outRegex(
<<<HELP
<bold>Usage:</bold> <brown>{$args[0]}</brown> [OPTIONS]\r\n
<bold>Options:</bold>\r
   --readme <brown>|</brown> -r\t<brown>Display the README file</brown>
   --extractdist <brown>|</brown> -e\t<brown>Extract the latest distribution data</brown>
   --check <brown>|</brown> -c\t\t<brown>Check for updates</brown>
   --selfupdate\t\t<brown>Upgrade Apix to the latest version available</brown>
   --version\t\t<brown>Display the version information and exit</brown>
   --info <brown>|</brown> -i\t\t<brown>PHP information and configuration</brown>
   --license\t\t<brown>Display the software license</brown>
   --syscheck <brown>|</brown> -s\t<brown>Run a system check</brown>
   --tests <brown>|</brown> -t\t\t<brown>Run some unit & functional tests</brown>
   --no-colors\t\t<brown>Don't use colors in the outputs</brown>
   --verbose <brown>|</brown> -v\t<brown>Add some verbosity to the outputs.\n\t\t\tMultiple -v options increase the verbosity.</brown>
   --help <brown>|</brown> -h\t\t<brown>Display this help</brown>\n\n
HELP
        );
        exit;

    }

    public function outputError(\Exception $e)
    {
        $this->out('Error: ', 'bold', 'red');
        $this->out("\tUnable to proceed.\n");

        if ($this->verbose > 1) {
            $this->out("\t" . $e->getMessage() . "\n");
        }

        $errors = error_get_last();
        if ($this->verbose == 3 && null !== $errors) {
            $this->out();
            print_r($errors);
        }

        $this->out();

        exit;

    }

    public function getContents($url, $method='GET', $body=null)
    {
        $opts = array('http' => array(
            'method'  => $method,
            'header'  => "Content-Type: text/xml\r\n".
            'Authorization: Basic ' . base64_encode($this->src_file . ":sesame") . "\r\n",
            'content' => $body,
            'timeout' => 60
            )
        );

        $ctx  = stream_context_create($opts);
        $body = @file_get_contents($url, false, $ctx);
        if (isset($http_response_header)) {
            $code = substr($http_response_header[0], 9, 3);
            if (floor($code/100)>3) {
                throw new \Exception($http_response_header[0]);
            }

            return $body;
        } else {
            throw new \Exception("Request failed.");
        }

        return null;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }

    protected function retrieveUpdate($url, $dest)
    {
        $temp = basename($dest, '.phar').'-temp.phar';

        try {
            copy($url, $temp);
            chmod($temp, 0777 & ~umask());

            // test the phar validity
            $phar = new \Phar($temp);
            // free the variable to unlock the file
            unset($phar);
            rename($temp, $dest);
        } catch (\Exception $e) {
            if (!$e instanceof \UnexpectedValueException&& !$e instanceof \PharException) {
                throw $e;
            }
            unlink($temp);
            $this->outputError('The dowloading ('.$e->getMessage().').');
            $output->out('Please re-run this again.');

        }

        $this->out($this->src_file . " has been updated.");
    }

    //     ini_set('phar.readonly', 0);

    //     if (true) {

    //         $this->out("Please, re-run this as: ");

    //         $this->out();

    //         $this->out('$ php -d phar.readonly=0 ' . $args[0], 'brown');

    //         exit(0);

    //     }
    //     if (false !== @file_put_contents($local, $this->getContents($url))) {

    //         $this->out($this->src_file . " has been updated.");

    //     } else {

    //          throw new \Exception;

    //     }
    // } catch (\Exception $e) {

    //     $this->outputError($e);


}


1			<?php
2
3			/**
4			*
5			* This file is part of the Apix Project.
6			*
7			* (c) Franck Cassedanne <franck at ouarz.net>
8			*
9			* @license http://opensource.org/licenses/BSD-3-Clause New BSD License
10			*
11			*/
12
13			namespace Apix\Console;
14
15			use Apix\Console,
16			Apix\Server,
17			Apix\Input;
18
19			/**
20			* Main Console class.
21			*
22			* @codeCoverageIgnore
23			*/
24			class Main extends Console
25			{
26
27			protected $version;
28			protected $version_program;
29
30			protected $src;
31			protected $src_file = 'apix.phar';
32			protected $src_url;
33
34			protected $phar_name = null;
35
36			public function __construct(array $options = null)
37			{
38			$this->src_url = 'http://api.ouarz.net/v1/%s/%s/in/%s';
39
40			#$this->src = realpath(__DIR__ . '/../../../../../');

frqnck / apix

Main::run() F last analyzed 2017-05-17 20:31 UTC

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like

Main::run() F
last analyzed 2017-05-17 20:31 UTC