Apix\Output\Xml\SimpleXml

Complexity

Total Complexity

7

Size/Duplication

Total Lines	70
Duplicated Lines	45.71 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

0%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	encode()	0	13	1
B	arrayToSimpleXml()	32	32	5
A	specialChars()	0	4	1

<?php

/**
 *
 * This file is part of the Apix Project.
 *
 * (c) Franck Cassedanne <franck at ouarz.net>
 *
 * @license     http://opensource.org/licenses/BSD-3-Clause  New BSD License
 *
 */

namespace Apix\Output\Xml;

use Apix\Output\Xml;

class SimpleXml extends Xml
{

    /**
     * SimpleXML handler
     * {@inheritdoc}
     */
    public function encode(array $data, $rootNode='root')
    {
        $str = sprintf('<?xml version="%s" encoding="%s"?><%s />',
            $this->version,
            $this->encoding,
            $rootNode
        );

        $x = new \SimpleXMLElement($str);
        $this->arrayToSimpleXml($x, $data);

        return $x->asXML();

The expression $x->asXML(); of type string|false adds false to the return on line 35 which is incompatible with the return type declared by the abstract method Apix\Output\AbstractOutput::encode of type string. It seems like you forgot to handle an error condition.

    }

    /**
     * Array to Simple XML
     *
     * @param \SimpleXMLElement $xml

There is no parameter named $xml. Was it maybe removed?

     * @param array             $array
     */
    protected function arrayToSimpleXml(\SimpleXMLElement $x, array $array)

This method seems to be duplicated in your project.

    {
        foreach ($array as $k => $v) {
            if (is_array($v)) {
                if (is_int($k)) {
                    $k = $this->items_key;
                }

                // @codeCoverageIgnoreStart
                // Attributes needs to be reviewd!!!
                #if ($k == '@attributes') {

55% of this comment could be valid code. Did you maybe forget this after debugging?

                #    foreach ($v as $k => $v) {

57% of this comment could be valid code. Did you maybe forget this after debugging?

                #        $x->addAttribute($k, $v);

73% of this comment could be valid code. Did you maybe forget this after debugging?

                #    }
                // @codeCoverageIgnoreEnd
                #} else {
                    $child = $x->addChild($k);
                    $this->arrayToSimpleXml($child, $v);
                #}
            } else {
                if (is_int($k)) {
                    $k = $this->item_key;
                }

                // $xml->addAttribute(
                //     $k,
                //     htmlspecialchars($v, ENT_QUOTES, $this->encoding)

54% of this comment could be valid code. Did you maybe forget this after debugging?

                // )
                $x->addChild($k, $this->specialChars($v));
            }
        }
    }

    /**
     * Decodes any special characters entities.
     * XmlWriter does this automatically.
     */
    public function specialChars($var)
    {
        return htmlspecialchars($var, ENT_COMPAT, $this->encoding);
    }

}