Modules\Core\Traits\Criteria\ParserOrderByTrait

Complexity

Total Complexity

8

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	multiOrderBy()	0	19	2
A	parserOrderBy()	0	14	5
A	orderBy()	0	3	1

<?php


namespace Modules\Core\Traits\Criteria;


use Illuminate\Support\Str;

/**
 * Trait ParserOrderByTrait
 *
 * @property \Illuminate\Http\Request $request
 * @property \Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Eloquent\Model|\Illuminate\Database\Query\Builder $model
 * @property $search
 * @property $searchData
 * @property $searchFields
 * @property $isFirstField = true
 * @property $modelForceAndWhere
 * @property $fieldsSearchable
 * @property $fields
 * @property $filter
 * @property $orderBy
 * @property $sortedBy
 * @property $with
 * @property $searchJoin
 * @property $acceptedConditions
 * @property $originalFields
 * @package Modules\Core\Traits\Criteria
 */

The doc comment $isFirstField at position 0 could not be parsed: Unknown type name '$isFirstField' at position 0 in $isFirstField.

trait ParserOrderByTrait
{
    protected function parserOrderBy()
    {
        $this->orderBy = $this->request->get(config('repository.criteria.params.orderBy', 'orderBy'), null);

The property orderBy does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->sortedBy = $this->request->get(config('repository.criteria.params.sortedBy', 'sortedBy'), 'asc');

The property sortedBy does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->sortedBy = !empty($this->sortedBy) ? $this->sortedBy : 'asc';

        if (isset($this->orderBy) && !empty($this->orderBy)) {

            $split = explode('|', $this->orderBy);

            if (count($split) > 1) {
                $this->multiOrderBy($split);
            } else {
                $this->orderBy();
            }
        }
    }

    protected function orderBy()
    {
        $this->model = $this->model->orderBy($this->orderBy, $this->sortedBy);

The property model does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    protected function multiOrderBy($split)
    {
        $table = $this->model->getModel()->getTable();
        $sortTable = $split[0];
        $sortColumn = $split[1];

        $split = explode(':', $sortTable);

        if (count($split) > 1) {
            $sortTable = $split[0];
            $keyName = $table.'.'.$split[1];
        } else {
            $prefix = Str::singular($sortTable);
            $keyName = $table.'.'.$prefix.'_id';
        }

        $this->model = $this->model->leftJoin($sortTable, $keyName, '=', $sortTable.'.id')

The property model does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

                                   ->orderBy($sortColumn, $this->sortedBy)
                                   ->addSelect($table.'.*');
    }
}