Modules\Core\Traits\Criteria\ParserWithTrait

Complexity

Total Complexity

2

Size/Duplication

Total Lines	9
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	parserWith()	0	7	2

<?php


namespace Modules\Core\Traits\Criteria;

/**
 * Class ParserWithTrait
 *
 * @property \Illuminate\Http\Request $request
 * @property \Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Eloquent\Model|\Illuminate\Database\Query\Builder $model
 * @package Modules\Core\Traits\Criteria
 */
trait ParserWithTrait
{
    protected function parserWith()
    {
        $this->with = $this->request->get(config('repository.criteria.params.with', 'with'), null);

The property with does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        if ($this->with) {
            $this->with = explode(';', $this->with);
            $this->model = $this->model->with($this->with);
        }
    }
}