Modules\Core\Traits\Criteria\ParserOrderByTrait

Complexity

Total Complexity

6

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
B	parserOrderBy()	0	27	6

<?php


namespace Modules\Core\Traits\Criteria;


use Illuminate\Support\Str;

/**
 * Trait ParserOrderByTrait
 *
 * @property \Illuminate\Http\Request $request
 * @property \Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Eloquent\Model|\Illuminate\Database\Query\Builder $model
 * @package Modules\Core\Traits\Criteria
 */
trait ParserOrderByTrait
{
    protected function parserOrderBy()
    {
        $this->orderBy = $this->request->get(config('repository.criteria.params.orderBy', 'orderBy'), null);

The property orderBy does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->sortedBy = $this->request->get(config('repository.criteria.params.sortedBy', 'sortedBy'), 'asc');

The property sortedBy does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->sortedBy = !empty($this->sortedBy) ? $this->sortedBy : 'asc';

        if (isset($this->orderBy) && !empty($this->orderBy)) {
            $split = explode('|', $this->orderBy);
            if (count($split) > 1) {
                $table = $this->model->getModel()->getTable();
                $sortTable = $split[0];
                $sortColumn = $split[1];

                $split = explode(':', $sortTable);
                if (count($split) > 1) {
                    $sortTable = $split[0];
                    $keyName = $table.'.'.$split[1];
                } else {
                    $prefix = Str::singular($sortTable);
                    $keyName = $table.'.'.$prefix.'_id';
                }

                $this->model = $this->model->leftJoin($sortTable, $keyName, '=', $sortTable.'.id')
                                           ->orderBy($sortColumn, $this->sortedBy)
                                           ->addSelect($table.'.*');
            } else {
                $this->model = $this->model->orderBy($this->orderBy, $this->sortedBy);
            }
        }
    }
}