freyo / mta-h5

src/Kernel/ServiceContainer.php

<?php

namespace Freyo\MtaH5\Kernel;

use Freyo\MtaH5\Kernel\Providers\BaseClientServiceProvider;
use Freyo\MtaH5\Kernel\Providers\ConfigServiceProvider;
use Freyo\MtaH5\Kernel\Providers\HttpClientServiceProvider;
use Freyo\MtaH5\Kernel\Providers\LogServiceProvider;
use Freyo\MtaH5\Kernel\Providers\RequestServiceProvider;
use Pimple\Container;

class ServiceContainer extends Container
{
    /**
     * @var array
     */
    protected $providers = [];

    /**
     * @var array
     */
    protected $defaultConfig = [];

    /**
     * @var array
     */
    protected $userConfig = [];

    /**
     * Constructor.
     *
     * @param array $config
     * @param array $prepends
     */
    public function __construct(array $config = [], array $prepends = [])
    {
        $this->registerProviders($this->getProviders());

        parent::__construct($prepends);

        $this->userConfig = $config;
    }

    /**
     * Return all providers.
     *
     * @return array
     */
    public function getProviders()
    {
        return array_merge([
            ConfigServiceProvider::class,
            LogServiceProvider::class,
            RequestServiceProvider::class,
            HttpClientServiceProvider::class,
            BaseClientServiceProvider::class,
        ], $this->providers);
    }

    /**
     * @param array $providers
     */
    public function registerProviders(array $providers)
    {
        foreach ($providers as $provider) {
            parent::register(new $provider());
        }
    }

    /**
     * Magic get access.
     *
     * @param string $id
     *
     * @return mixed
     */
    public function __get($id)
    {
        return $this->offsetGet($id);
    }

    /**
     * Magic set access.
     *
     * @param string $id
     * @param mixed  $value
     */
    public function __set($id, $value)
    {
        $this->offsetSet($id, $value);
    }

    /**
     * @return string
     */
    public function getId()
    {
        return $this->id ?: ($this->id = md5(json_encode($this->userConfig)));

The property id does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    /**
     * @return array
     */
    public function getConfig()
    {
        $base = [
            // http://docs.guzzlephp.org/en/stable/request-options.html
            'http' => [
                'timeout'  => 5.0,
                'base_uri' => 'https://mta.qq.com/h5/api/',
            ],
        ];

        return array_replace_recursive($base, $this->defaultConfig, $this->userConfig);
    }

    /**
     * @return string
     */
    public function getSecretKey()
    {
        return $this->config->get('secret_key');

The property config does not exist on Freyo\MtaH5\Kernel\ServiceContainer. Since you implemented __get, consider adding a @property annotation.

    }

    /**
     * @return string
     */
    public function getAppId()
    {
        return $this->config->get('app_id');

The property config does not exist on Freyo\MtaH5\Kernel\ServiceContainer. Since you implemented __get, consider adding a @property annotation.

    }
}