Issues in MessageBuilder.php (master) - Issues in master - freyo/entwechat - Measure and Improve Code Quality continuously with Scrutinizer

Issues (108)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Staff/MessageBuilder.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace EntWeChat\Staff;

use EntWeChat\Core\Exceptions\InvalidArgumentException;
use EntWeChat\Core\Exceptions\RuntimeException;
use EntWeChat\Message\AbstractMessage;
use EntWeChat\Message\Raw as RawMessage;
use EntWeChat\Message\Text;

/**
 * Class MessageBuilder.
 */
class MessageBuilder
{
    /**
     * Message to send.
     *
     * @var \EntWeChat\Message\AbstractMessage;
     */
    protected $message;

    /**
     * Message receiver.
     *
     * @var array
     */
    protected $to;

    /**
     * Message sender.
     *
     * @var array
     */
    protected $by;

    /**
     * Staff instance.
     *
     * @var \EntWeChat\Staff\Staff
     */
    protected $staff;

    /**
     * User types.
     *
     * @var array
     */
    private $userTypes = [

        Staff::USER_TYPE_STAFF,
        Staff::USER_TYPE_USERID,
        Staff::USER_TYPE_OPENID,
    ];

    /**
     * MessageBuilder constructor.
     *
     * @param \EntWeChat\Staff\Staff $staff
     */
    public function __construct(Staff $staff)
    {
        $this->staff = $staff;
    }

    /**
     * Set message to send.
     *
     * @param string|AbstractMessage $message
     *
     * @throws InvalidArgumentException
     *
     * @return MessageBuilder
     */
    public function message($message)

    {
        if (is_string($message)) {
            $message = new Text(['content' => $message]);
        }

        $this->message = $message;

        return $this;
    }

    /**
     * Set staff account to send message.
     *
     * @param string $type
     * @param string $id
     *
     * @return MessageBuilder
     */
    public function by($type, $id)
    {
        $this->account = [
class MyClass { }

$x = new MyClass();
$x->foo = true;
            'type' => $type,
            'id'   => $id,
        ];

        return $this;
    }

    /**
     * Set target user open id.
     *
     * @param string $type
     * @param string $id
     *
     * @return MessageBuilder
     */
    public function to($type, $id)
    {
        $this->to = [
            'type' => $type,
            'id'   => $id,
        ];

        return $this;
    }

    /**
     * Send the message.
     *
     * @throws RuntimeException
     *
     * @return bool
     */
    public function send()

    {
        if (empty($this->message)) {
            throw new RuntimeException('No message to send.');
        }

        $transformer = new Transformer();

        if ($this->message instanceof RawMessage) {
            $message = $this->message->get('content');
        } else {
            $content = $transformer->transform($this->message);
            $message = [
                'sender'   => $this->by,
                'receiver' => $this->to,
            ];

            $message = array_merge($message, $content);
        }

        return $this->staff->send($message);
    }

    /**
     * Return property.
     *
     * @param $property
     *
     * @return mixed
     */
    public function __get($property)
    {
        if (property_exists($this, $property)) {
            return $this->$property;
        }
    }
}


1		<?php
2
3		namespace EntWeChat\Staff;
4
5		use EntWeChat\Core\Exceptions\InvalidArgumentException;
6		use EntWeChat\Core\Exceptions\RuntimeException;
7		use EntWeChat\Message\AbstractMessage;
8		use EntWeChat\Message\Raw as RawMessage;
9		use EntWeChat\Message\Text;
10
11		/**
12		* Class MessageBuilder.
13		*/
14		class MessageBuilder
15		{
16		/**
17		* Message to send.
18		*
19		* @var \EntWeChat\Message\AbstractMessage;
20		*/
21		protected $message;
22
23		/**
24		* Message receiver.
25		*
26		* @var array
27		*/
28		protected $to;
29
30		/**
31		* Message sender.
32		*
33		* @var array
34		*/
35		protected $by;
36
37		/**
38		* Staff instance.
39		*
40		* @var \EntWeChat\Staff\Staff
41		*/
42		protected $staff;
43
44		/**
45		* User types.
46		*
47		* @var array
48		*/
49		private $userTypes = [
		0 ignored issues – show Unused Code introduced 2017-04-23 03:01 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$userTypes` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
50		Staff::USER_TYPE_STAFF,
51		Staff::USER_TYPE_USERID,
52		Staff::USER_TYPE_OPENID,
53		];
54
55		/**
56		* MessageBuilder constructor.
57		*
58		* @param \EntWeChat\Staff\Staff $staff
59		*/
60		public function __construct(Staff $staff)
61		{
62		$this->staff = $staff;
63		}
64
65		/**
66		* Set message to send.
67		*
68		* @param string\|AbstractMessage $message
69		*
70		* @throws InvalidArgumentException
71		*
72		* @return MessageBuilder
73		*/
74	View Code Duplication	public function message($message)
		0 ignored issues – show Duplication introduced 2017-12-09 15:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
75		{
76		if (is_string($message)) {
77		$message = new Text(['content' => $message]);
78		}
79
80		$this->message = $message;
81
82		return $this;
83		}
84
85		/**
86		* Set staff account to send message.
87		*
88		* @param string $type
89		* @param string $id
90		*
91		* @return MessageBuilder
92		*/
93		public function by($type, $id)
94		{
95		$this->account = [
		0 ignored issues – show Bug introduced 2017-04-23 03:01 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `account` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
96		'type' => $type,
97		'id' => $id,
98		];
99
100		return $this;
101		}
102
103		/**
104		* Set target user open id.
105		*
106		* @param string $type
107		* @param string $id
108		*
109		* @return MessageBuilder
110		*/
111		public function to($type, $id)
112		{
113		$this->to = [
114		'type' => $type,
115		'id' => $id,
116		];
117
118		return $this;
119		}
120
121		/**
122		* Send the message.
123		*
124		* @throws RuntimeException
125		*
126		* @return bool
127		*/
128	View Code Duplication	public function send()
		0 ignored issues – show Duplication introduced 2017-12-09 15:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
129		{
130		if (empty($this->message)) {
131		throw new RuntimeException('No message to send.');
132		}
133
134		$transformer = new Transformer();
135
136		if ($this->message instanceof RawMessage) {
137		$message = $this->message->get('content');
138		} else {
139		$content = $transformer->transform($this->message);
140		$message = [
141		'sender' => $this->by,
142		'receiver' => $this->to,
143		];
144
145		$message = array_merge($message, $content);
146		}
147
148		return $this->staff->send($message);
149		}
150
151		/**
152		* Return property.
153		*
154		* @param $property
155		*
156		* @return mixed
157		*/
158		public function __get($property)
159		{
160		if (property_exists($this, $property)) {
161		return $this->$property;
162		}
163		}
164		}
165

freyo / entwechat

Issues (108)

Security Analysis not enabled

src/Staff/MessageBuilder.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like