EntWeChat\Suite\Api\AbstractSuite

Complexity

Total Complexity

2

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	getSuiteId()	0	4	1

<?php

namespace EntWeChat\Suite\Api;

use EntWeChat\Core\AbstractAPI;
use EntWeChat\Suite\AccessToken;
use Symfony\Component\HttpFoundation\Request;

abstract class AbstractSuite extends AbstractAPI
{
    /**
     * Request.
     *
     * @var \Symfony\Component\HttpFoundation\Request
     */
    protected $request;

    /**
     * AbstractSuite constructor.
     *
     * @param \EntWeChat\Suite\AccessToken              $accessToken
     * @param \Symfony\Component\HttpFoundation\Request $request
     */
    public function __construct(AccessToken $accessToken, Request $request)

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

    {
        parent::__construct($accessToken);

        $this->request = $request;
    }

    /**
     * Get Suite Id.
     *
     * @return string
     */
    public function getSuiteId()
    {
        return $this->getAccessToken()->getId();
    }
}