Department::delete() - Code Metrics - freyo/entwechat - Measure and Improve Code Quality continuously with Scrutinizer

Department::delete() A
last analyzed 2017-12-09 15:09 UTC

↳ Parent: Department

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	4

Duplication

Lines	8
Ratio	100 %

Importance

Changes

Metric	Value
cc	1
eloc	4
nc	1
nop	1
dl	8
loc	8
rs	9.4285
c	0
b	0
f	0

<?php

namespace EntWeChat\User;

use EntWeChat\Core\AbstractAPI;

/**
 * Class Department.
 */
class Department extends AbstractAPI
{
    const API_GET = 'https://qyapi.weixin.qq.com/cgi-bin/department/list';
    const API_CREATE = 'https://qyapi.weixin.qq.com/cgi-bin/department/create';
    const API_UPDATE = 'https://qyapi.weixin.qq.com/cgi-bin/department/update';
    const API_DELETE = 'https://qyapi.weixin.qq.com/cgi-bin/department/delete';

    /**
     * Create Department.
     *
     * @param string   $name
     * @param int      $parentId
     * @param int|null $order
     * @param int|null $partyId
     *
     * @return int
     */
    public function create($name, $parentId, $order = null, $partyId = null)
    {
        $params = [
            'name'     => $name,
            'parentid' => $parentId,
            'order'    => $order,
            'id'       => $partyId,
        ];

        return $this->parseJSON('json', [self::API_CREATE, $params]);
    }

    /**
     * List all Departments.
     *
     * @return array
     */
    public function lists($partyId = null)

    {
        $params = [
            'id' => $partyId,
        ];

        return $this->parseJSON('get', [self::API_GET, $params]);
    }

    /**
     * Update a Department.
     *
     * @param int   $partyId
     * @param array $name
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return bool
     */
    public function update($partyId, array $partyInfo = [])
    {
        $params = array_merge($partyInfo, ['id' => $partyId]);

        return $this->parseJSON('json', [self::API_UPDATE, $params]);
    }

    /**
     * Delete Department.
     *
     * @param int $groupId
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return bool
     */
    public function delete($partyId)

    {
        $params = [
            'id' => $partyId,
        ];

        return $this->parseJSON('json', [self::API_DELETE, $params]);
    }
}


1		<?php
2
3		namespace EntWeChat\User;
4
5		use EntWeChat\Core\AbstractAPI;
6
7		/**
8		* Class Department.
9		*/
10		class Department extends AbstractAPI
11		{
12		const API_GET = 'https://qyapi.weixin.qq.com/cgi-bin/department/list';
13		const API_CREATE = 'https://qyapi.weixin.qq.com/cgi-bin/department/create';
14		const API_UPDATE = 'https://qyapi.weixin.qq.com/cgi-bin/department/update';
15		const API_DELETE = 'https://qyapi.weixin.qq.com/cgi-bin/department/delete';
16
17		/**
18		* Create Department.
19		*
20		* @param string $name
21		* @param int $parentId
22		* @param int\|null $order
23		* @param int\|null $partyId
24		*
25		* @return int
26		*/
27		public function create($name, $parentId, $order = null, $partyId = null)
28		{
29		$params = [
30		'name' => $name,
31		'parentid' => $parentId,
32		'order' => $order,
33		'id' => $partyId,
34		];
35
36		return $this->parseJSON('json', [self::API_CREATE, $params]);
37		}
38
39		/**
40		* List all Departments.
41		*
42		* @return array
43		*/
44	View Code Duplication	public function lists($partyId = null)
		0 ignored issues – show Duplication introduced 2017-12-09 15:09 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
45		{
46		$params = [
47		'id' => $partyId,
48		];
49
50		return $this->parseJSON('get', [self::API_GET, $params]);
51		}
52
53		/**
54		* Update a Department.
55		*
56		* @param int $partyId
57		* @param array $name
		0 ignored issues – show Bug introduced 2017-04-23 03:01 UTC by Report Bug Copy Issue Report There is no parameter named `$name`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
58		*
59		* @return bool
60		*/
61		public function update($partyId, array $partyInfo = [])
62		{
63		$params = array_merge($partyInfo, ['id' => $partyId]);
64
65		return $this->parseJSON('json', [self::API_UPDATE, $params]);
66		}
67
68		/**
69		* Delete Department.
70		*
71		* @param int $groupId
		0 ignored issues – show Bug introduced 2017-04-23 03:01 UTC by Report Bug Copy Issue Report There is no parameter named `$groupId`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
72		*
73		* @return bool
74		*/
75	View Code Duplication	public function delete($partyId)
		0 ignored issues – show Duplication introduced 2017-12-09 15:09 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
76		{
77		$params = [
78		'id' => $partyId,
79		];
80
81		return $this->parseJSON('json', [self::API_DELETE, $params]);
82		}
83		}
84

freyo / entwechat

Department::delete() A last analyzed 2017-12-09 15:09 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Department::delete() A
last analyzed 2017-12-09 15:09 UTC