Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
12 | class Transformer |
||
13 | { |
||
14 | /** |
||
15 | * transform message to XML. |
||
16 | * |
||
17 | * @param array|string|AbstractMessage $message |
||
18 | * |
||
19 | * @return array |
||
20 | */ |
||
21 | View Code Duplication | public function transform($message) |
|
37 | |||
38 | /** |
||
39 | * Transform text message. |
||
40 | * |
||
41 | * @return array |
||
42 | */ |
||
43 | public function transformText(AbstractMessage $message) |
||
52 | |||
53 | /** |
||
54 | * Transform image message. |
||
55 | * |
||
56 | * @return array |
||
57 | */ |
||
58 | public function transformImage(AbstractMessage $message) |
||
67 | |||
68 | /** |
||
69 | * Transform music message. |
||
70 | * |
||
71 | * @return array |
||
72 | */ |
||
73 | View Code Duplication | public function transformMusic(AbstractMessage $message) |
|
86 | |||
87 | /** |
||
88 | * Transform video message. |
||
89 | * |
||
90 | * @return array |
||
91 | */ |
||
92 | View Code Duplication | public function transformVideo(AbstractMessage $message) |
|
104 | |||
105 | /** |
||
106 | * Transform voice message. |
||
107 | * |
||
108 | * @return array |
||
109 | */ |
||
110 | public function transformVoice(AbstractMessage $message) |
||
119 | |||
120 | /** |
||
121 | * Transform file message. |
||
122 | * |
||
123 | * @return array |
||
124 | */ |
||
125 | public function transformFile(AbstractMessage $message) |
||
134 | |||
135 | /** |
||
136 | * Transform articles message. |
||
137 | * |
||
138 | * @return array |
||
139 | */ |
||
140 | View Code Duplication | public function transformNews($news) |
|
160 | |||
161 | /** |
||
162 | * Transform articles message. |
||
163 | * |
||
164 | * @return array |
||
165 | */ |
||
166 | public function transformMpNews($news) |
||
188 | |||
189 | /** |
||
190 | * Transform material message. |
||
191 | * |
||
192 | * @return array |
||
193 | */ |
||
194 | View Code Duplication | public function transformMaterial(AbstractMessage $message) |
|
205 | |||
206 | /** |
||
207 | * Transform textcard message. |
||
208 | * |
||
209 | * @return array |
||
210 | */ |
||
211 | public function transformTextCard(AbstractMessage $message) |
||
223 | |||
224 | /** |
||
225 | * Transform card message. |
||
226 | * |
||
227 | * @param $message |
||
228 | * |
||
229 | * @return array |
||
230 | */ |
||
231 | public function transformCard($message) |
||
240 | } |
||
241 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.