FH\Bundle\MultiSiteBundle\Site\PrefixedPathIdentifiedSiteResolver::resolve()

Complexity

Conditions	9
Paths	20

Size

Total Lines	33
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function resolve(RequestContext $requestContext): SiteInterface
    {
        $matches = [];

        if (preg_match('#^/([^/]+)/?#', $requestContext->getPathInfo(), $matches) > 0) {
            $identifier = $matches[1];
        } else {
            $identifier = $this->defaultIdentifier;
        }

        if (empty($identifier)) {
            throw SiteNotFoundException::withRequestContext($requestContext);
        }

        foreach ($this->siteRepository->findAll() as $site) {
            if (!$site instanceof IdentifiedSiteInterface) {
                continue;
            }

            if ($site->matches($identifier)) {
                return $site;
            }

            if ($site->matches($this->defaultIdentifier)) {

It seems like $this->defaultIdentifier can also be of type null; however, parameter $identifier of FH\Bundle\MultiSiteBundle\Site\IdentifiedSiteInterface::matches() does only seem to accept string, maybe add an additional type check?

                $defaultSite = $site;
            }
        }

        if (!empty($defaultSite) && $defaultSite instanceof IdentifiedSiteInterface) {
            return $defaultSite;
        }

        throw SiteNotFoundException::withRequestContext($requestContext);
    }