fre5h /
FirebaseCloudMessagingBundle
| Conditions | 10 |
| Paths | 512 |
| Total Lines | 42 |
| Code Lines | 21 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 35 | public function build(): self |
||
| 36 | { |
||
| 37 | $this->payloadPart = []; |
||
| 38 | |||
| 39 | if (!empty($this->payload->getTitle())) { |
||
| 40 | $this->payloadPart['title'] = (string) $this->payload->getTitle(); |
||
| 41 | } |
||
| 42 | |||
| 43 | if (!empty($this->payload->getBody())) { |
||
| 44 | $this->payloadPart['body'] = (string) $this->payload->getBody(); |
||
| 45 | } |
||
| 46 | |||
| 47 | if (!empty($this->payload->getSound())) { |
||
| 48 | $this->payloadPart['sound'] = (string) $this->payload->getSound(); |
||
| 49 | } |
||
| 50 | |||
| 51 | if (!empty($this->payload->getBadge())) { |
||
| 52 | $this->payloadPart['badge'] = (string) $this->payload->getBadge(); |
||
| 53 | } |
||
| 54 | |||
| 55 | if (!empty($this->payload->getClickAction())) { |
||
| 56 | $this->payloadPart['click_action'] = (string) $this->payload->getClickAction(); |
||
| 57 | } |
||
| 58 | |||
| 59 | if (!empty($this->payload->getBodyLocKey())) { |
||
| 60 | $this->payloadPart['body_loc_key'] = (string) $this->payload->getBodyLocKey(); |
||
| 61 | } |
||
| 62 | |||
| 63 | if (!empty($this->payload->getBodyLocArgs())) { |
||
| 64 | $this->payloadPart['body_loc_args'] = (array) $this->payload->getBodyLocArgs(); |
||
| 65 | } |
||
| 66 | |||
| 67 | if (!empty($this->payload->getTitleLocKey())) { |
||
| 68 | $this->payloadPart['title_loc_key'] = (string) $this->payload->getTitleLocKey(); |
||
| 69 | } |
||
| 70 | |||
| 71 | if (!empty($this->payload->getTitleLocArgs())) { |
||
| 72 | $this->payloadPart['title_loc_args'] = (array) $this->payload->getTitleLocArgs(); |
||
| 73 | } |
||
| 74 | |||
| 75 | return $this; |
||
| 76 | } |
||
| 77 | } |
||
| 78 |
Loading history...
Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property.
Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property..