Issues in ResponseProcessor.php (master) - Issues in master - fre5h/CentrifugoBundle - Measure and Improve Code Quality continuously with Scrutinizer

Issues (39)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Service/ResponseProcessor.php (1 issue)

Labels

Bug 1

Severity

Critical 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*
 * This file is part of the FreshCentrifugoBundle.
 *
 * (c) Artem Henvald <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Fresh\CentrifugoBundle\Service;

use Fresh\CentrifugoBundle\Exception\CentrifugoErrorException;
use Fresh\CentrifugoBundle\Exception\CentrifugoException;
use Fresh\CentrifugoBundle\Exception\LogicException;
use Fresh\CentrifugoBundle\Logger\CommandHistoryLogger;
use Fresh\CentrifugoBundle\Model\BatchRequest;
use Fresh\CentrifugoBundle\Model\CommandInterface;
use Fresh\CentrifugoBundle\Model\ResultableCommandInterface;
use Symfony\Component\HttpKernel\Profiler\Profiler;
use Symfony\Contracts\HttpClient\ResponseInterface;

/**
 * ResponseProcessor.
 *
 * @author Artem Henvald <[email protected]>
 */
class ResponseProcessor
{
    private CentrifugoChecker $centrifugoChecker;

    private bool $profilerEnabled;
    private CommandHistoryLogger $commandHistoryLogger;
    private array $centrifugoError = [];

    /**
     * @param CentrifugoChecker    $centrifugoChecker
     * @param CommandHistoryLogger $commandHistoryLogger
     * @param Profiler|null        $profiler
     */
    public function __construct(CentrifugoChecker $centrifugoChecker, CommandHistoryLogger $commandHistoryLogger, ?Profiler $profiler)
    {
        $this->centrifugoChecker = $centrifugoChecker;
        $this->profilerEnabled = $profiler instanceof Profiler;
        $this->commandHistoryLogger = $commandHistoryLogger;
    }

    /**
     * @param CommandInterface  $command
     * @param ResponseInterface $response
     *
     * @throws LogicException
     * @throws CentrifugoErrorException
     *
     * @return array|null
     */
    public function processResponse(CommandInterface $command, ResponseInterface $response): ?array
    {
        $this->centrifugoChecker->assertValidResponseStatusCode($response);
        $this->centrifugoChecker->assertValidResponseHeaders($response);
        $this->centrifugoChecker->assertValidResponseContentType($response);

        $this->centrifugoError = [];

        $content = $response->getContent();

        if ($command instanceof BatchRequest) {
            $contents = \explode("\n", \rtrim($content, "\n"));
            $result = [];

            if (\count($contents) !== $command->getNumberOfCommands()) {
                throw new LogicException('Number of commands doesn\'t match number of responses');
            }

            $i = 0;
            foreach ($command->getCommands() as $innerCommand) {
                $result[] = $this->decodeAndProcessResponseResult($innerCommand, $contents[$i]);
                ++$i;
            }
        } else {
            $result = $this->decodeAndProcessResponseResult($command, $content);
        }

        if (isset($this->centrifugoError['message'], $this->centrifugoError['code'])) {
            throw new CentrifugoErrorException($this->centrifugoError['message'], $this->centrifugoError['code']);
        }

        return $result;
    }

    /**
     * @param CommandInterface $command
     * @param string           $content
     *
     * @throws CentrifugoException
     *
     * @return array|null
     */
    private function decodeAndProcessResponseResult(CommandInterface $command, string $content): ?array
    {
        try {
            $data = \json_decode($content, true, 512, \JSON_THROW_ON_ERROR);
        } catch (\Exception $e) {
            throw new CentrifugoException('Centrifugo response payload is not a valid JSON');
        }

        $successfulCommand = true;
        $result = null;

        if (isset($data['error'])) {
            if (empty($this->centrifugoError)) {
                $this->centrifugoError = [
                    'message' => $data['error']['message'],
                    'code' => $data['error']['code'],
                ];
            }

            $result = $data;
            $successfulCommand = false;
        } elseif ($command instanceof ResultableCommandInterface) {
            $result = $data['result'];
        }

        if ($this->profilerEnabled) {
            $this->commandHistoryLogger->logCommand($command, $successfulCommand, $result);
        }

        return $result;
    }
}


1			<?php
2			/*
3			* This file is part of the FreshCentrifugoBundle.
4			*
5			* (c) Artem Henvald <[email protected]>
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*/
10
11			declare(strict_types=1);
12
13			namespace Fresh\CentrifugoBundle\Service;
14
15			use Fresh\CentrifugoBundle\Exception\CentrifugoErrorException;
16			use Fresh\CentrifugoBundle\Exception\CentrifugoException;
17			use Fresh\CentrifugoBundle\Exception\LogicException;
18			use Fresh\CentrifugoBundle\Logger\CommandHistoryLogger;
19			use Fresh\CentrifugoBundle\Model\BatchRequest;
20			use Fresh\CentrifugoBundle\Model\CommandInterface;
21			use Fresh\CentrifugoBundle\Model\ResultableCommandInterface;
22			use Symfony\Component\HttpKernel\Profiler\Profiler;
23			use Symfony\Contracts\HttpClient\ResponseInterface;
24
25			/**
26			* ResponseProcessor.
27			*
28			* @author Artem Henvald <[email protected]>
29			*/
30			class ResponseProcessor
31			{
32			private CentrifugoChecker $centrifugoChecker;
			0 ignored issues – show Bug introduced 2021-03-04 13:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected T_STRING, expecting T_FUNCTION or T_CONST Loading history...
33			private bool $profilerEnabled;
34			private CommandHistoryLogger $commandHistoryLogger;
35			private array $centrifugoError = [];
36
37			/**
38			* @param CentrifugoChecker $centrifugoChecker
39			* @param CommandHistoryLogger $commandHistoryLogger
40			* @param Profiler\|null $profiler
41			*/
42			public function __construct(CentrifugoChecker $centrifugoChecker, CommandHistoryLogger $commandHistoryLogger, ?Profiler $profiler)
43			{
44			$this->centrifugoChecker = $centrifugoChecker;
45			$this->profilerEnabled = $profiler instanceof Profiler;
46			$this->commandHistoryLogger = $commandHistoryLogger;
47			}
48
49			/**
50			* @param CommandInterface $command
51			* @param ResponseInterface $response
52			*
53			* @throws LogicException
54			* @throws CentrifugoErrorException
55			*
56			* @return array\|null
57			*/
58			public function processResponse(CommandInterface $command, ResponseInterface $response): ?array
59			{
60			$this->centrifugoChecker->assertValidResponseStatusCode($response);
61			$this->centrifugoChecker->assertValidResponseHeaders($response);
62			$this->centrifugoChecker->assertValidResponseContentType($response);
63
64			$this->centrifugoError = [];
65
66			$content = $response->getContent();
67
68			if ($command instanceof BatchRequest) {
69			$contents = \explode("\n", \rtrim($content, "\n"));
70			$result = [];
71
72			if (\count($contents) !== $command->getNumberOfCommands()) {
73			throw new LogicException('Number of commands doesn\'t match number of responses');
74			}
75
76			$i = 0;
77			foreach ($command->getCommands() as $innerCommand) {
78			$result[] = $this->decodeAndProcessResponseResult($innerCommand, $contents[$i]);
79			++$i;
80			}
81			} else {
82			$result = $this->decodeAndProcessResponseResult($command, $content);
83			}
84
85			if (isset($this->centrifugoError['message'], $this->centrifugoError['code'])) {
86			throw new CentrifugoErrorException($this->centrifugoError['message'], $this->centrifugoError['code']);
87			}
88
89			return $result;
90			}
91
92			/**
93			* @param CommandInterface $command
94			* @param string $content
95			*
96			* @throws CentrifugoException
97			*
98			* @return array\|null
99			*/
100			private function decodeAndProcessResponseResult(CommandInterface $command, string $content): ?array
101			{
102			try {
103			$data = \json_decode($content, true, 512, \JSON_THROW_ON_ERROR);
104			} catch (\Exception $e) {
105			throw new CentrifugoException('Centrifugo response payload is not a valid JSON');
106			}
107
108			$successfulCommand = true;
109			$result = null;
110
111			if (isset($data['error'])) {
112			if (empty($this->centrifugoError)) {
113			$this->centrifugoError = [
114			'message' => $data['error']['message'],
115			'code' => $data['error']['code'],
116			];
117			}
118
119			$result = $data;
120			$successfulCommand = false;
121			} elseif ($command instanceof ResultableCommandInterface) {
122			$result = $data['result'];
123			}
124
125			if ($this->profilerEnabled) {
126			$this->commandHistoryLogger->logCommand($command, $successfulCommand, $result);
127			}
128
129			return $result;
130			}
131			}
132

fre5h / CentrifugoBundle

Issues (39)

Security Analysis no request data

Service/ResponseProcessor.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like