Issues in CentrifugoChecker.php (master) - Issues in master - fre5h/CentrifugoBundle - Measure and Improve Code Quality continuously with Scrutinizer

Issues (39)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Service/CentrifugoChecker.php (1 issue)

Labels

Bug 1

Severity

Critical 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*
 * This file is part of the FreshCentrifugoBundle.
 *
 * (c) Artem Henvald <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Fresh\CentrifugoBundle\Service;

use Fresh\CentrifugoBundle\Exception\CentrifugoException;
use Fresh\CentrifugoBundle\Exception\InvalidArgumentException;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Contracts\HttpClient\ResponseInterface;

/**
 * CentrifugoChecker.
 *
 * @author Artem Henvald <[email protected]>
 */
class CentrifugoChecker
{
    private int $channelMaxLength;


    /**
     * @param int $centrifugoChannelMaxLength
     */
    public function __construct(int $centrifugoChannelMaxLength)
    {
        $this->channelMaxLength = $centrifugoChannelMaxLength;
    }

    /**
     * @param string $channelName
     *
     * @throws InvalidArgumentException
     *
     * @return bool
     */
    public function assertValidChannelName(string $channelName): bool
    {
        if (false === \mb_detect_encoding($channelName, 'ASCII', true)) {
            throw new InvalidArgumentException('Invalid channel name. Only ASCII symbols must be used in channel string.');
        }

        if (\strlen($channelName) > $this->channelMaxLength) {
            throw new InvalidArgumentException(\sprintf('Invalid channel name length. Maximum allowed length is %d.', $this->channelMaxLength));
        }

        return true;
    }

    /**
     * @param ResponseInterface $response
     *
     * @throws CentrifugoException
     */
    public function assertValidResponseStatusCode(ResponseInterface $response): void
    {
        if (Response::HTTP_OK !== $response->getStatusCode()) {
            throw new CentrifugoException('Wrong status code for Centrifugo response');
        }
    }

    /**
     * @param ResponseInterface $response
     *
     * @throws CentrifugoException
     */
    public function assertValidResponseHeaders(ResponseInterface $response): void
    {
        $headers = $response->getHeaders(false);

        if (!isset($headers['content-type'])) {
            throw new CentrifugoException('Missing "content-type" header in Centrifugo response');
        }
    }

    /**
     * @param ResponseInterface $response
     *
     * @throws CentrifugoException
     */
    public function assertValidResponseContentType(ResponseInterface $response): void
    {
        $headers = $response->getHeaders(false);

        if (!\in_array('application/json', $headers['content-type'], true)) {
            throw new CentrifugoException('Unexpected content type for Centrifugo response');
        }
    }
}


1			<?php
2			/*
3			* This file is part of the FreshCentrifugoBundle.
4			*
5			* (c) Artem Henvald <[email protected]>
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*/
10
11			declare(strict_types=1);
12
13			namespace Fresh\CentrifugoBundle\Service;
14
15			use Fresh\CentrifugoBundle\Exception\CentrifugoException;
16			use Fresh\CentrifugoBundle\Exception\InvalidArgumentException;
17			use Symfony\Component\HttpFoundation\Response;
18			use Symfony\Contracts\HttpClient\ResponseInterface;
19
20			/**
21			* CentrifugoChecker.
22			*
23			* @author Artem Henvald <[email protected]>
24			*/
25			class CentrifugoChecker
26			{
27			private int $channelMaxLength;
			0 ignored issues – show Bug introduced 2021-03-04 13:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected T_STRING, expecting T_FUNCTION or T_CONST Loading history...
28
29			/**
30			* @param int $centrifugoChannelMaxLength
31			*/
32			public function __construct(int $centrifugoChannelMaxLength)
33			{
34			$this->channelMaxLength = $centrifugoChannelMaxLength;
35			}
36
37			/**
38			* @param string $channelName
39			*
40			* @throws InvalidArgumentException
41			*
42			* @return bool
43			*/
44			public function assertValidChannelName(string $channelName): bool
45			{
46			if (false === \mb_detect_encoding($channelName, 'ASCII', true)) {
47			throw new InvalidArgumentException('Invalid channel name. Only ASCII symbols must be used in channel string.');
48			}
49
50			if (\strlen($channelName) > $this->channelMaxLength) {
51			throw new InvalidArgumentException(\sprintf('Invalid channel name length. Maximum allowed length is %d.', $this->channelMaxLength));
52			}
53
54			return true;
55			}
56
57			/**
58			* @param ResponseInterface $response
59			*
60			* @throws CentrifugoException
61			*/
62			public function assertValidResponseStatusCode(ResponseInterface $response): void
63			{
64			if (Response::HTTP_OK !== $response->getStatusCode()) {
65			throw new CentrifugoException('Wrong status code for Centrifugo response');
66			}
67			}
68
69			/**
70			* @param ResponseInterface $response
71			*
72			* @throws CentrifugoException
73			*/
74			public function assertValidResponseHeaders(ResponseInterface $response): void
75			{
76			$headers = $response->getHeaders(false);
77
78			if (!isset($headers['content-type'])) {
79			throw new CentrifugoException('Missing "content-type" header in Centrifugo response');
80			}
81			}
82
83			/**
84			* @param ResponseInterface $response
85			*
86			* @throws CentrifugoException
87			*/
88			public function assertValidResponseContentType(ResponseInterface $response): void
89			{
90			$headers = $response->getHeaders(false);
91
92			if (!\in_array('application/json', $headers['content-type'], true)) {
93			throw new CentrifugoException('Unexpected content type for Centrifugo response');
94			}
95			}
96			}
97

fre5h / CentrifugoBundle

Issues (39)

Security Analysis no request data

Service/CentrifugoChecker.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like