PrivateChannelAuthenticator::processRequest() - Code Metrics - Inspection of "Upgrade to PHP 7.4" - fre5h/CentrifugoBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#14)

by Artem

created 2021-03-04 13:48 UTC

PrivateChannelAuthenticator::processRequest() B

↳ Parent: Project

Complexity

Conditions	10
Paths	7

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	31
rs	7.6666
c	0
b	0
f	0
cc	10
nc	7
nop	1

How to fix Complexity

<?php
/*
 * This file is part of the FreshCentrifugoBundle.
 *
 * (c) Artem Henvald <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Fresh\CentrifugoBundle\Service\ChannelAuthenticator;

use Fresh\CentrifugoBundle\Service\Credentials\CredentialsGenerator;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;

/**
 * PrivateChannelAuthenticator.
 *
 * @author Artem Henvald <[email protected]>
 */
class PrivateChannelAuthenticator
{
    private CredentialsGenerator $credentialsGenerator;


    /** @var ChannelAuthenticatorInterface[]|iterable */
    private iterable $channelAuthenticators;

    /**
     * @param CredentialsGenerator                     $credentialsGenerator
     * @param ChannelAuthenticatorInterface[]|iterable $channelAuthenticators
     */
    public function __construct(CredentialsGenerator $credentialsGenerator, iterable $channelAuthenticators)
    {
        $this->credentialsGenerator = $credentialsGenerator;
        $this->channelAuthenticators = $channelAuthenticators;
    }

    /**
     * @param Request $request
     *
     * @return array
     */
    public function authChannelsForClientFromRequest(Request $request): array
    {
        $authData = [];

        [$client, $channels] = $this->processRequest($request);

        foreach ($channels as $channel) {
            $token = $this->authChannelForClient($client, (string) $channel);

            if (\is_string($token)) {
                $authData[] = [
                    'channel' => (string) $channel,
                    'token' => $token,
                ];
            }
        }

        return ['channels' => $authData];
    }

    /**
     * @param string $client
     * @param string $channel
     *
     * @return string|null
     */
    private function authChannelForClient(string $client, string $channel): ?string
    {
        $token = null;

        $channelAuthenticator = $this->findAppropriateChannelAuthenticator($channel);
        if ($channelAuthenticator instanceof ChannelAuthenticatorInterface && $channelAuthenticator->hasAccessToChannel($channel)) {
            $token = $this->credentialsGenerator->generateJwtTokenForPrivateChannel($client, $channel);
        }

        return $token;
    }

    /**
     * @param string $channel
     *
     * @return ChannelAuthenticatorInterface|null
     */
    private function findAppropriateChannelAuthenticator(string $channel): ?ChannelAuthenticatorInterface
    {
        foreach ($this->channelAuthenticators as $channelAuthenticator) {
            if ($channelAuthenticator->supports($channel)) {
                return $channelAuthenticator;
            }
        }

        return null;
    }

    /**
     * @param Request $request
     *
     * @throws BadRequestHttpException
     * @throws \Exception
     *
     * @return array
     */
    private function processRequest(Request $request): array
    {
        try {
            $content = \json_decode((string) $request->getContent(), true, 512, \JSON_THROW_ON_ERROR);
        } catch (\JsonException $e) {
            throw new BadRequestHttpException('Invalid JSON.');
        } catch (\Exception $e) {
            throw $e;
        }

        $result = [];

        if (!isset($content['client']) || !\is_string($content['client'])) {
            throw new BadRequestHttpException('Client must be set in request.');
        }
        $result[] = $content['client'];

        if (!isset($content['channels']) || !\is_array($content['channels']) || empty($content['channels'])) {
            throw new BadRequestHttpException('Channels must be set in request.');
        }

        foreach ($content['channels'] as $channel) {
            if (!\is_string($channel)) {
                throw new BadRequestHttpException('Channel must be a string.');
            }
        }

        $result[] = $content['channels'];

        return $result;
    }
}


1			<?php
2			/*
3			* This file is part of the FreshCentrifugoBundle.
4			*
5			* (c) Artem Henvald <[email protected]>
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*/
10
11			declare(strict_types=1);
12
13			namespace Fresh\CentrifugoBundle\Service\ChannelAuthenticator;
14
15			use Fresh\CentrifugoBundle\Service\Credentials\CredentialsGenerator;
16			use Symfony\Component\HttpFoundation\Request;
17			use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
18
19			/**
20			* PrivateChannelAuthenticator.
21			*
22			* @author Artem Henvald <[email protected]>
23			*/
24			class PrivateChannelAuthenticator
25			{
26			private CredentialsGenerator $credentialsGenerator;
			0 ignored issues – show Bug introduced 2021-03-04 13:54 UTC by Report Bug Copy Issue Report This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected T_STRING, expecting T_FUNCTION or T_CONST Loading history...
27
28			/** @var ChannelAuthenticatorInterface[]\|iterable */
29			private iterable $channelAuthenticators;
30
31			/**
32			* @param CredentialsGenerator $credentialsGenerator
33			* @param ChannelAuthenticatorInterface[]\|iterable $channelAuthenticators
34			*/
35			public function __construct(CredentialsGenerator $credentialsGenerator, iterable $channelAuthenticators)
36			{
37			$this->credentialsGenerator = $credentialsGenerator;
38			$this->channelAuthenticators = $channelAuthenticators;
39			}
40
41			/**
42			* @param Request $request
43			*
44			* @return array
45			*/
46			public function authChannelsForClientFromRequest(Request $request): array
47			{
48			$authData = [];
49
50			[$client, $channels] = $this->processRequest($request);
51
52			foreach ($channels as $channel) {
53			$token = $this->authChannelForClient($client, (string) $channel);
54
55			if (\is_string($token)) {
56			$authData[] = [
57			'channel' => (string) $channel,
58			'token' => $token,
59			];
60			}
61			}
62
63			return ['channels' => $authData];
64			}
65
66			/**
67			* @param string $client
68			* @param string $channel
69			*
70			* @return string\|null
71			*/
72			private function authChannelForClient(string $client, string $channel): ?string
73			{
74			$token = null;
75
76			$channelAuthenticator = $this->findAppropriateChannelAuthenticator($channel);
77			if ($channelAuthenticator instanceof ChannelAuthenticatorInterface && $channelAuthenticator->hasAccessToChannel($channel)) {
78			$token = $this->credentialsGenerator->generateJwtTokenForPrivateChannel($client, $channel);
79			}
80
81			return $token;
82			}
83
84			/**
85			* @param string $channel
86			*
87			* @return ChannelAuthenticatorInterface\|null
88			*/
89			private function findAppropriateChannelAuthenticator(string $channel): ?ChannelAuthenticatorInterface
90			{
91			foreach ($this->channelAuthenticators as $channelAuthenticator) {
92			if ($channelAuthenticator->supports($channel)) {
93			return $channelAuthenticator;
94			}
95			}
96
97			return null;
98			}
99
100			/**
101			* @param Request $request
102			*
103			* @throws BadRequestHttpException
104			* @throws \Exception
105			*
106			* @return array
107			*/
108			private function processRequest(Request $request): array
109			{
110			try {
111			$content = \json_decode((string) $request->getContent(), true, 512, \JSON_THROW_ON_ERROR);
112			} catch (\JsonException $e) {
113			throw new BadRequestHttpException('Invalid JSON.');
114			} catch (\Exception $e) {
115			throw $e;
116			}
117
118			$result = [];
119
120			if (!isset($content['client']) \|\| !\is_string($content['client'])) {
121			throw new BadRequestHttpException('Client must be set in request.');
122			}
123			$result[] = $content['client'];
124
125			if (!isset($content['channels']) \|\| !\is_array($content['channels']) \|\| empty($content['channels'])) {
126			throw new BadRequestHttpException('Channels must be set in request.');
127			}
128
129			foreach ($content['channels'] as $channel) {
130			if (!\is_string($channel)) {
131			throw new BadRequestHttpException('Channel must be a string.');
132			}
133			}
134
135			$result[] = $content['channels'];
136
137			return $result;
138			}
139			}
140

fre5h / CentrifugoBundle

Pull Request — master (#14)

PrivateChannelAuthenticator::processRequest() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like