ArgumentChannelTrait::initializeChannelArgument() - Code Metrics - Inspection of "Improvements" - fre5h/CentrifugoBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1)

by Artem

created 2020-05-06 14:13 UTC

ArgumentChannelTrait::initializeChannelArgument() A

↳ Parent: ArgumentChannelTrait

Complexity

Conditions	3
Paths	5

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	15
rs	9.7666
c	0
b	0
f	0
cc	3
nc	5
nop	1

<?php
/*
 * This file is part of the FreshCentrifugoBundle.
 *
 * (c) Artem Henvald <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Fresh\CentrifugoBundle\Command;

use Symfony\Component\Console\Exception\InvalidArgumentException;
use Symfony\Component\Console\Input\InputInterface;

/**
 * ArgumentChannelTrait.
 *
 * @author Artem Henvald <[email protected]>
 */
trait ArgumentChannelTrait
{
    /** @var string */
    protected $channel;

    /**
     * @param InputInterface $input
     *
     * @throws InvalidArgumentException
     */
    protected function initializeChannelArgument(InputInterface $input): void
    {
        try {
            $channel = $input->getArgument('channel');

            if (!\is_string($channel)) {
                throw new InvalidArgumentException('Argument "channel" is not a string.');
            }

            $this->centrifugoChecker->assertValidChannelName($channel);
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $this->channel = $channel;
        } catch (\Exception $e) {
            throw new InvalidArgumentException($e->getMessage());
        }
    }
}


1			<?php
2			/*
3			* This file is part of the FreshCentrifugoBundle.
4			*
5			* (c) Artem Henvald <[email protected]>
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*/
10
11			declare(strict_types=1);
12
13			namespace Fresh\CentrifugoBundle\Command;
14
15			use Symfony\Component\Console\Exception\InvalidArgumentException;
16			use Symfony\Component\Console\Input\InputInterface;
17
18			/**
19			* ArgumentChannelTrait.
20			*
21			* @author Artem Henvald <[email protected]>
22			*/
23			trait ArgumentChannelTrait
24			{
25			/** @var string */
26			protected $channel;
27
28			/**
29			* @param InputInterface $input
30			*
31			* @throws InvalidArgumentException
32			*/
33			protected function initializeChannelArgument(InputInterface $input): void
34			{
35			try {
36			$channel = $input->getArgument('channel');
37
38			if (!\is_string($channel)) {
39			throw new InvalidArgumentException('Argument "channel" is not a string.');
40			}
41
42			$this->centrifugoChecker->assertValidChannelName($channel);
			0 ignored issues – show Bug introduced 2020-05-06 13:42 UTC by Report Bug Copy Issue Report The property `centrifugoChecker` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
43			$this->channel = $channel;
44			} catch (\Exception $e) {
45			throw new InvalidArgumentException($e->getMessage());
46			}
47			}
48			}
49

fre5h / CentrifugoBundle

Pull Request — master (#1)

ArgumentChannelTrait::initializeChannelArgument() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like