@@ -65,11 +65,17 @@ |
||
65 | 65 | { |
66 | 66 | http_response_code($this->code ?? 200); |
67 | 67 | |
68 | - if ($this->json) header('Content-Type: application/json'); |
|
68 | + if ($this->json) { |
|
69 | + header('Content-Type: application/json'); |
|
70 | + } |
|
69 | 71 | |
70 | - if ($this->data !== null) echo !$this->json ? $this->data : json_encode($this->data, JSON_PRETTY_PRINT|JSON_UNESCAPED_SLASHES); |
|
72 | + if ($this->data !== null) { |
|
73 | + echo !$this->json ? $this->data : json_encode($this->data, JSON_PRETTY_PRINT|JSON_UNESCAPED_SLASHES); |
|
74 | + } |
|
71 | 75 | |
72 | - if ($exit) exit(EXIT_SUCCESS); |
|
76 | + if ($exit) { |
|
77 | + exit(EXIT_SUCCESS); |
|
78 | + } |
|
73 | 79 | } |
74 | 80 | } |
75 | 81 | ?> |
@@ -81,10 +81,14 @@ discard block |
||
81 | 81 | $this->db->or_where($this->users_username_column, $username); |
82 | 82 | } |
83 | 83 | $query = $this->db->get(); |
84 | - if ($query->num_rows() == 0) return false; |
|
84 | + if ($query->num_rows() == 0) { |
|
85 | + return false; |
|
86 | + } |
|
85 | 87 | // Authenticate. |
86 | 88 | if (password_verify($password, $query->result()[0]->{$this->users_password_column})) { |
87 | - if ($this->users_id_column != null) $context->userId = $query->result()[0]->{$this->users_id_column}; |
|
89 | + if ($this->users_id_column != null) { |
|
90 | + $context->userId = $query->result()[0]->{$this->users_id_column}; |
|
91 | + } |
|
88 | 92 | return true; |
89 | 93 | } |
90 | 94 | return false; |
@@ -97,7 +101,9 @@ discard block |
||
97 | 101 | */ |
98 | 102 | public function getAPIKeyData(string $apiKey):?object { |
99 | 103 | // Preliminary Check. |
100 | - if ($this->api_key_table == null || $this->api_key_column == null) return null; |
|
104 | + if ($this->api_key_table == null || $this->api_key_column == null) { |
|
105 | + return null; |
|
106 | + } |
|
101 | 107 | // Query. |
102 | 108 | $this->db->from($this->api_key_table); |
103 | 109 | $this->db->where($this->api_key_column, $apiKey); |
@@ -122,7 +128,9 @@ discard block |
||
122 | 128 | public function getLimitData(string $client, string $group):?array { |
123 | 129 | $sql = 'SELECT count, start, (`start` + INTERVAL (1 - TIMESTAMPDIFF(HOUR, UTC_TIMESTAMP(), NOW())) HOUR) AS reset_epoch FROM rest_api_rate_limit WHERE client = ? AND _group = ?'; |
124 | 130 | $query = $this->db->query($sql, [$client, $group]); |
125 | - if (!is_scalar($query) && $query->num_rows() > 0) return $query->result_array()[0]; |
|
131 | + if (!is_scalar($query) && $query->num_rows() > 0) { |
|
132 | + return $query->result_array()[0]; |
|
133 | + } |
|
126 | 134 | return null; |
127 | 135 | } |
128 | 136 | /** |
@@ -127,7 +127,9 @@ discard block |
||
127 | 127 | { |
128 | 128 | $this->ci =& get_instance(); |
129 | 129 | |
130 | - if ($this->ci->input->is_cli_request()) return; |
|
130 | + if ($this->ci->input->is_cli_request()) { |
|
131 | + return; |
|
132 | + } |
|
131 | 133 | |
132 | 134 | // Load Config If Exists. |
133 | 135 | //$this->ci->config->load('rest', true, true); |
@@ -200,7 +202,9 @@ discard block |
||
200 | 202 | |
201 | 203 | $globalAuths = $this->config['global_auth'] ?? null; |
202 | 204 | |
203 | - if ($globalAuths) $auths = is_array($globalAuths) ? $globalAuths : [$globalAuths]; |
|
205 | + if ($globalAuths) { |
|
206 | + $auths = is_array($globalAuths) ? $globalAuths : [$globalAuths]; |
|
207 | + } |
|
204 | 208 | |
205 | 209 | $uri_auths = $this->config['uri_auth'] ?? null; |
206 | 210 | |
@@ -226,7 +230,10 @@ discard block |
||
226 | 230 | } |
227 | 231 | |
228 | 232 | //$auths = $this->config['uri_auth'][uri_string()] ?? null; |
229 | - if (!$auths) return; // No authentication(s) to carry out. |
|
233 | + if (!$auths) { |
|
234 | + return; |
|
235 | + } |
|
236 | + // No authentication(s) to carry out. |
|
230 | 237 | |
231 | 238 | // $this->process_auth() terminates the script if authentication fails |
232 | 239 | // It will call the callable in the rest.php config file under |
@@ -238,7 +245,9 @@ discard block |
||
238 | 245 | //return; |
239 | 246 | //} |
240 | 247 | |
241 | - foreach ($auths as $auth) $this->process_auth($auth); |
|
248 | + foreach ($auths as $auth) { |
|
249 | + $this->process_auth($auth); |
|
250 | + } |
|
242 | 251 | } |
243 | 252 | /** |
244 | 253 | * [process_auth description] |
@@ -294,15 +303,23 @@ discard block |
||
294 | 303 | private function basic_auth():void { |
295 | 304 | $username = $_SERVER['PHP_AUTH_USER'] ?? null; |
296 | 305 | $password = $_SERVER['PHP_AUTH_PW'] ?? null; |
297 | - if (!$username || !$password) $this->handle_response(RESTResponse::BAD_REQUEST, RESTAuth::BASIC); // Exits. |
|
298 | - if (!$this->rest_model->basicAuth($this, $username, $password)) $this->handle_response(RESTResponse::UN_AUTHORIZED, RESTAuth::BASIC); // Exits. |
|
306 | + if (!$username || !$password) { |
|
307 | + $this->handle_response(RESTResponse::BAD_REQUEST, RESTAuth::BASIC); |
|
308 | + } |
|
309 | + // Exits. |
|
310 | + if (!$this->rest_model->basicAuth($this, $username, $password)) { |
|
311 | + $this->handle_response(RESTResponse::UN_AUTHORIZED, RESTAuth::BASIC); |
|
312 | + } |
|
313 | + // Exits. |
|
299 | 314 | } |
300 | 315 | /** |
301 | 316 | * [api_key_auth description] |
302 | 317 | */ |
303 | 318 | private function api_key_auth():void |
304 | 319 | { |
305 | - if (uri_string() == '') return; |
|
320 | + if (uri_string() == '') { |
|
321 | + return; |
|
322 | + } |
|
306 | 323 | |
307 | 324 | if (!$this->ci->input->get_request_header($this->apiKeyHeader, true)) { |
308 | 325 | // if (!isset($_SERVER['HTTP_' . str_replace("-", "_", $this->apiKeyHeader)])) { |
@@ -364,7 +381,9 @@ discard block |
||
364 | 381 | // Trunctate Rate Limit Data. |
365 | 382 | $this->rest_model->truncateRatelimitData(); |
366 | 383 | // Check Whitelist. |
367 | - if (in_array($this->ci->input->ip_address(), $this->whitelist)) return; |
|
384 | + if (in_array($this->ci->input->ip_address(), $this->whitelist)) { |
|
385 | + return; |
|
386 | + } |
|
368 | 387 | // Should we acyually Limit? |
369 | 388 | if ($this->ip_per_hour > 0) { |
370 | 389 | $client = hash('md5', $this->ci->input->ip_address()); |
@@ -444,7 +463,9 @@ discard block |
||
444 | 463 | if (isset($this->config['response_callbacks'][$code])) { |
445 | 464 | $this->config['response_callbacks'][$code]($auth, $errorReason); |
446 | 465 | } |
447 | - if (ENVIRONMENT != 'testing') exit($code); |
|
466 | + if (ENVIRONMENT != 'testing') { |
|
467 | + exit($code); |
|
468 | + } |
|
448 | 469 | throw new Exception("Error $code in $auth", $code); |
449 | 470 | } |
450 | 471 | } |