francis94c / ci-gmail

libraries/GMailCURL.php

<?php

declare(strict_types=1);

defined('BASEPATH') OR exit('No direct script access allowed');


class GMailCURL {


  const GET  = 'GET';

  const POST = 'POST';


  private $method;

  private $userAgent;


  function __construct(string $method, string $userAgent='CodeIgniter GMail API') {

    $this->method = $method;

    $this->userAgent = $userAgent;

  }


  function __invoke(string $url, array $header=[], array $body=null):array {

It is generally recommended to explicitly declare the visibility for methods.

    if ($body != null) $body = json_encode($body);


    $ch = curl_init($url);


    // Defaults.

    curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);

It seems like $ch can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

    curl_setopt($ch, CURLINFO_HEADER_OUT, true);

    if (ENVIRONMENT == 'development') {

The constant ENVIRONMENT was not found. Maybe you did not declare it correctly or list all dependencies?

      curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, false);

    }

    // Header.

    $header[] = 'Content-Type: application/json';

    if ($body != null)  {

It seems like you are loosely comparing $body of type null|string against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

      $header[] = 'Content-Length: '.strlen($body);

    } else {

      $header[] = 'Content-Length: 0';

    }

    curl_setopt($ch, CURLOPT_HTTPHEADER, $header);

    curl_setopt($ch, CURLOPT_USERAGENT, $this->userAgent);

    // Request Method and Body.

    if ($this->method == self::POST) {

      curl_setopt($ch, CURLOPT_POST, true);

      if ($body != null) {

It seems like you are loosely comparing $body of type null|string against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

        curl_setopt($ch, CURLOPT_POSTFIELDS, $body);

      }

    }

    // Exec.

    $response = curl_exec($ch);

It seems like $ch can also be of type false; however, parameter $ch of curl_exec() does only seem to accept resource, maybe add an additional type check?

    $code = curl_getinfo($ch, CURLINFO_HTTP_CODE);

It seems like $ch can also be of type false; however, parameter $ch of curl_getinfo() does only seem to accept resource, maybe add an additional type check?

    curl_close($ch);

It seems like $ch can also be of type false; however, parameter $ch of curl_close() does only seem to accept resource, maybe add an additional type check?

    return [$code, $response];

  }

}