URLQueryBuilder

Complexity

Total Complexity

6

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	GMailCURL::__construct()	0	3	1

<?php
declare(strict_types=1);
defined('BASEPATH') OR exit('No direct script access allowed');

class GMailCURL {

  const GET  = 'GET';
  const POST = 'POST';

  private $method;
  private $userAgent;

  function __construct(string $method, string $userAgent='CodeIgniter GMail API') {
    $this->method = $method;
    $this->userAgent = $userAgent;
  }

  function __invoke(string $url, array $header=[], mixed $body=null):array {

It is generally recommended to explicitly declare the visibility for methods.

The type mixed was not found. Maybe you did not declare it correctly or list all dependencies?

    if ($body != null) $body = json_encode($body);

    $ch = curl_init($url);

    // Defaults.
    curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);

It seems like $ch can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

    curl_setopt($ch, CURLINFO_HEADER_OUT, true);
    // Header.
    $header[] = 'Content-Type: application/json';
    $header[] = 'User-Agent: '.$this->userAgent;
    if ($body != null) $header[] = 'Content-Length: '.strlen($body);

It seems like you are loosely comparing $body of type null|string against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

    curl_setopt($ch, CURLOPT_HTTPHEADER, $header);
    // Request Method and Body.
    if ($this->method == self::POST) {
      curl_setopt($ch, CURLOPT_POST, true);
      if ($body != null) {

It seems like you are loosely comparing $body of type null|string against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

        curl_setopt($ch, CURLOPT_POSTFIELDS, $body);
      }
    }
    // Exec.
    $result = curl_exec($ch);

It seems like $ch can also be of type false; however, parameter $ch of curl_exec() does only seem to accept resource, maybe add an additional type check?

    $code = curl_getinfo($ch, CURLINFO_HTTP_CODE);

It seems like $ch can also be of type false; however, parameter $ch of curl_getinfo() does only seem to accept resource, maybe add an additional type check?

    curl_close($ch);

It seems like $ch can also be of type false; however, parameter $ch of curl_close() does only seem to accept resource, maybe add an additional type check?

    return [
      'code'   => $code,
      'result' => $result
    ];
  }
}