Reaction - Code Metrics - Inspection of "Fix namespaces introducing vendor level" - francescomalatesta/laravel-reactions - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3e9aa7...1cfafa )

by Francesco

created 2017-03-25 21:44 UTC

Reaction A

↳ Parent: Reaction

Complexity

Total Complexity

Size/Duplication

Total Lines	19
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	19
c	1
b	0
f	0
wmc	3
lcom	0
cbo	1
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
A	createFromName()	0	7	1

<?php

namespace FrancescoMalatesta\LaravelReactions\Models;

use Illuminate\Database\Eloquent\Model;

class Reaction extends Model
{
    public static function createFromName($name)
    {
        $reaction = new static;
        $reaction->name = $name;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        return $reaction;
    }

    public function getReagent()
    {
        if ($this->getOriginal('pivot_reagent_type', null)) {
            return forward_static_call(
                [$this->getOriginal('pivot_reagent_type'), 'find'],
                $this->getOriginal('pivot_reagent_id')
            );
        }

        return null;
    }
}


1			<?php
2
3			namespace FrancescoMalatesta\LaravelReactions\Models;
4
5			use Illuminate\Database\Eloquent\Model;
6
7			class Reaction extends Model
8			{
9			public static function createFromName($name)
10			{
11			$reaction = new static;
12			$reaction->name = $name;
			0 ignored issues – show Documentation introduced 2017-03-25 21:47 UTC by Report Bug Copy Issue Report The property `name` does not exist on `object<FrancescoMalatest...ctions\Models\Reaction>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
13
14			return $reaction;
15			}
16
17			public function getReagent()
18			{
19			if ($this->getOriginal('pivot_reagent_type', null)) {
20			return forward_static_call(
21			[$this->getOriginal('pivot_reagent_type'), 'find'],
22			$this->getOriginal('pivot_reagent_id')
23			);
24			}
25
26			return null;
27			}
28			}
29

francescomalatesta / laravel-reactions

Push — master ( 3e9aa7...1cfafa )

Reaction A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like