FileCatalog::offsetSet() - Code Metrics - Inspection of "Multiple API changes" - fracture/http - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#11)

by Mārtiņš

created 2016-03-19 22:15 UTC

FileCatalog::offsetSet() A

↳ Parent: FileCatalog

Complexity

Conditions	4
Paths	3

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	14
ccs	9
cts	9
cp	1
rs	9.2
cc	4
eloc	8
nc	3
nop	2
crap	4

<?php

namespace Fracture\Http;

class FileCatalog implements \Iterator, \ArrayAccess
{

    private $entries = [];

    private $current = 0;


    // implementing Iterator interface
    public function current()
    {
        return $this->entries[$this->current];
    }


    public function key()
    {
        return $this->current;
    }


    public function next()
    {
        $this->current += 1;
    }


    public function rewind()
    {
        $this->current = 0;
    }


    public function valid()
    {
        return isset($this->entries[$this->current]);
    }


    // implementing ArrayAccess interface
    public function offsetExists($offset)
    {
        return isset($this->entries[$offset]);
    }


    public function offsetSet($offset, $value)
    {
        // attempts to add invalid file in a filebag are ignored
        if (is_a($value, 'Fracture\Http\UploadedFile') === true &&
            $value->isValid() === false) {
            return;
        }

        if (is_null($offset) === true) {
            $this->entries[] = $value;
        } else {
            $this->entries[$offset] = $value;
        }
    }


    public function offsetGet($offset)
    {
        if (array_key_exists($offset, $this->entries)) {
            return $this->entries[$offset];
        }

        return null;
    }


    public function offsetUnset($offset)
    {
        unset($this->entries[$offset]);
    }
}


1		<?php
2
3		namespace Fracture\Http;
4
5		class FileCatalog implements \Iterator, \ArrayAccess
6		{
7
8		private $entries = [];
9
10		private $current = 0;
11
12
13		// implementing Iterator interface
14	1	public function current()
15		{
16	1	return $this->entries[$this->current];
17		}
18
19
20	1	public function key()
21		{
22	1	return $this->current;
23		}
24
25
26	1	public function next()
27		{
28	1	$this->current += 1;
29	1	}
30
31
32	2	public function rewind()
33		{
34	2	$this->current = 0;
35	2	}
36
37
38	2	public function valid()
39		{
40	2	return isset($this->entries[$this->current]);
41		}
42
43
44		// implementing ArrayAccess interface
45	3	public function offsetExists($offset)
46		{
47	3	return isset($this->entries[$offset]);
48		}
49
50
51	3	public function offsetSet($offset, $value)
52		{
53		// attempts to add invalid file in a filebag are ignored
54	3	if (is_a($value, 'Fracture\Http\UploadedFile') === true &&
55	3	$value->isValid() === false) {
56	1	return;
57		}
58
59	2	if (is_null($offset) === true) {
60	1	$this->entries[] = $value;
61	1	} else {
62	1	$this->entries[$offset] = $value;
63		}
64	2	}
65
66
67	2	public function offsetGet($offset)
68		{
69	2	if (array_key_exists($offset, $this->entries)) {
70	1	return $this->entries[$offset];
71		}
72
73	1	return null;
74		}
75
76
77	2	public function offsetUnset($offset)
78		{
79	2	unset($this->entries[$offset]);
80	2	}
81		}
82

fracture / http

Pull Request — master (#11)

FileCatalog::offsetSet() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like