fractalzombie / frzb-metrics-power

OptionsResolver/Resolver/SentryOptionsResolver.php

<?php

declare(strict_types=1);

/**
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
 * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
 *
 * Copyright (c) 2024 Mykhailo Shtanko fractalzombie@gmail.com
 *
 * For the full copyright and license information, please view the LICENSE.MD
 * file that was distributed with this source code.
 */

namespace FRZB\Component\MetricsPower\OptionsResolver\Resolver;

use FRZB\Component\DependencyInjection\Attribute\AsService;
use FRZB\Component\DependencyInjection\Attribute\AsTagged;
use FRZB\Component\MetricsPower\Attribute\SentryOptions;

The type FRZB\Component\MetricsPower\Attribute\SentryOptions was not found. Maybe you did not declare it correctly or list all dependencies?

use Sentry\State\HubInterface;
use Symfony\Component\Messenger\Event\AbstractWorkerMessageEvent;
use Symfony\Component\Messenger\Event\SendMessageToTransportsEvent;
use Symfony\Component\Messenger\Event\WorkerMessageFailedEvent;
use Symfony\Component\Messenger\Event\WorkerMessageHandledEvent;

#[AsService, AsTagged(OptionsResolverInterface::class)]
class SentryOptionsResolver implements OptionsResolverInterface
{
    public function __construct(
        private readonly HubInterface $hub
    ) {}

    public function resolve(AbstractWorkerMessageEvent|SendMessageToTransportsEvent $event, SentryOptions $options): void
    {
        match ($event::class) {
            WorkerMessageFailedEvent::class => $this->onWorkerMessageFailedEvent($event, $options),

It seems like $event can also be of type Symfony\Component\Messenger\Event\SendMessageToTransportsEvent; however, parameter $event of FRZB\Component\MetricsPower\OptionsResolver\Resolver\SentryOptionsResolver::onWorkerMessageFailedEvent() does only seem to accept Symfony\Component\Messenger\Event\WorkerMessageFailedEvent, maybe add an additional type check?

Are you sure the usage of $this->onWorkerMessageFailedEvent($event, $options) targeting FRZB\Component\MetricsPower\OptionsResolver\Resolver\SentryOptionsResolver::onWorkerMessageFailedEvent() seems to always return null.

            WorkerMessageHandledEvent::class => $this->onWorkerMessageHandledEvent($event, $options),

It seems like $event can also be of type Symfony\Component\Messenger\Event\SendMessageToTransportsEvent; however, parameter $event of FRZB\Component\MetricsPower\OptionsResolver\Resolver\SentryOptionsResolver::onWorkerMessageHandledEvent() does only seem to accept Symfony\Component\Messenger\Event\WorkerMessageHandledEvent, maybe add an additional type check?

Are you sure the usage of $this->onWorkerMessageHandledEvent($event, $options) targeting FRZB\Component\MetricsPower\OptionsResolver\Resolver\SentryOptionsResolver::onWorkerMessageHandledEvent() seems to always return null.

            default => null,
        };
    }

    public static function getType(): string
    {
        return SentryOptions::class;
    }

    private function onWorkerMessageFailedEvent(WorkerMessageFailedEvent $event, SentryOptions $options): void
    {
        if ($event->willRetry() && $options->waitRetry) {
            return;
        }

        $this->hub->captureException($event->getThrowable());
    }

    private function onWorkerMessageHandledEvent(WorkerMessageHandledEvent $event, SentryOptions $options): void

The parameter $event is not used and could be removed.

    {
        $options->onHandleFlush && $this->hub->getClient()?->flush();
    }
}