Issues (48)

OptionsResolver/Resolver/LoggerOptionsResolver.php (5 issues)

1
<?php
2
3
declare(strict_types=1);
4
5
/**
6
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
7
 * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
8
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
9
 *
10
 * Copyright (c) 2024 Mykhailo Shtanko [email protected]
11
 *
12
 * For the full copyright and license information, please view the LICENSE.MD
13
 * file that was distributed with this source code.
14
 */
15
16
namespace FRZB\Component\MetricsPower\OptionsResolver\Resolver;
17
18
use FRZB\Component\DependencyInjection\Attribute\AsService;
19
use FRZB\Component\DependencyInjection\Attribute\AsTagged;
20
use FRZB\Component\MetricsPower\Attribute\LoggerOptions;
0 ignored issues
show
The type FRZB\Component\MetricsPo...Attribute\LoggerOptions was not found. Maybe you did not declare it correctly or list all dependencies?

The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:

filter:
    dependency_paths: ["lib/*"]

For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths

Loading history...
21
use FRZB\Component\MetricsPower\Logger\MetricsPowerLoggerInterface;
22
use Symfony\Component\Messenger\Event\AbstractWorkerMessageEvent;
23
use Symfony\Component\Messenger\Event\SendMessageToTransportsEvent;
24
use Symfony\Component\Messenger\Event\WorkerMessageFailedEvent;
25
26
#[AsService, AsTagged(OptionsResolverInterface::class)]
27
class LoggerOptionsResolver implements OptionsResolverInterface
28
{
29
    public function __construct(
30
        private readonly MetricsPowerLoggerInterface $logger,
31
    ) {}
32
33
    public function resolve(AbstractWorkerMessageEvent|SendMessageToTransportsEvent $event): void
34
    {
35
        match ($event::class) {
36
            WorkerMessageFailedEvent::class => $this->logger->error($event, $event->getThrowable()),
0 ignored issues
show
The method getThrowable() does not exist on Symfony\Component\Messen...essageToTransportsEvent. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

36
            WorkerMessageFailedEvent::class => $this->logger->error($event, $event->/** @scrutinizer ignore-call */ getThrowable()),

This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.

This is most likely a typographical error or the method has been renamed.

Loading history...
Are you sure the usage of $this->logger->error($ev...$event->getThrowable()) targeting FRZB\Component\MetricsPo...oggerInterface::error() seems to always return null.

This check looks for function or method calls that always return null and whose return value is used.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

The method getObject() can return nothing but null, so it makes no sense to use the return value.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
The method getThrowable() does not exist on Symfony\Component\Messen...tractWorkerMessageEvent. It seems like you code against a sub-type of Symfony\Component\Messen...tractWorkerMessageEvent such as Symfony\Component\Messen...orkerMessageFailedEvent. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

36
            WorkerMessageFailedEvent::class => $this->logger->error($event, $event->/** @scrutinizer ignore-call */ getThrowable()),
Loading history...
37
            default => $this->logger->info($event),
0 ignored issues
show
Are you sure the usage of $this->logger->info($event) targeting FRZB\Component\MetricsPo...LoggerInterface::info() seems to always return null.

This check looks for function or method calls that always return null and whose return value is used.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

The method getObject() can return nothing but null, so it makes no sense to use the return value.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
38
        };
39
    }
40
41
    public static function getType(): string
42
    {
43
        return LoggerOptions::class;
44
    }
45
}
46