AppController::add() - Code Metrics - Inspection of "Added ability to submit issues to Jira." - fr3nch13/cakephp-jira - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#8)

by Brian

created 2019-11-27 04:06 UTC

AppController::add() A

↳ Parent: AppController

Complexity

Conditions	4
Paths	5

Size

Total Lines	21
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	4
eloc	13
nc	5
nop	0
dl	0
loc	21
ccs	0
cts	18
cp	0
crap	20
rs	9.8333
c	2
b	0
f	0

<?php

/**
 * AppController
 */

namespace Fr3nch13\Jira\Controller;

use App\Controller\AppController as BaseController;

/**
 * App Controller
 *
 * The base controller for the jira plugin.
 *
 * -----------------------------
 * Inherited:
 *
 * {@inheritdoc}
 */
class AppController extends BaseController
{
    /**
     * Human name of this object.
     * @var string
     */
    public $humanName = '';

    /**
     * The form object.
     * @var object|null
     */
    public $JiraForm = null;

    /**
     * The html form.
     *
     * @return void|\Cake\Http\Response|null Redirects on success.
     */
    public function add()
    {
        $errors = [];
        if ($this->getRequest()->is('post')) {
            if ($this->JiraForm->execute($this->getRequest()->getData())) {
                $this->Flash->success(__('The {0} has been saved.', [$this->humanName]));

                return $this->redirect(['action' => 'thankyou', '?' => ['type' => $this->humanName]]);
            } else {
                $errors = $this->JiraForm->getErrors();
                $this->Flash->error(__('There was a problem saving the {0}.', [$this->humanName]));
            }
        }

        if ($this->getRequest()->is('get')) {
            $this->JiraForm->setData($this->JiraForm->getFormData());
        }

        $this->set([
            'form' => $this->JiraForm,
            'errors' => $errors
        ]);
    }

    /**
     * The thank you page after they've submitted their report.
     *
     * @return void
     */
    public function thankyou()
    {
        //
    }
}


1			<?php
2
3			/**
4			* AppController
5			*/
6
7			namespace Fr3nch13\Jira\Controller;
8
9			use App\Controller\AppController as BaseController;
10
11			/**
12			* App Controller
13			*
14			* The base controller for the jira plugin.
15			*
16			* -----------------------------
17			* Inherited:
18			*
19			* {@inheritdoc}
20			*/
21			class AppController extends BaseController
22			{
23			/**
24			* Human name of this object.
25			* @var string
26			*/
27			public $humanName = '';
28
29			/**
30			* The form object.
31			* @var object\|null
32			*/
33			public $JiraForm = null;
34
35			/**
36			* The html form.
37			*
38			* @return void\|\Cake\Http\Response\|null Redirects on success.
39			*/
40			public function add()
41			{
42			$errors = [];
43			if ($this->getRequest()->is('post')) {
44			if ($this->JiraForm->execute($this->getRequest()->getData())) {
45			$this->Flash->success(__('The {0} has been saved.', [$this->humanName]));
46
47			return $this->redirect(['action' => 'thankyou', '?' => ['type' => $this->humanName]]);
48			} else {
49			$errors = $this->JiraForm->getErrors();
50			$this->Flash->error(__('There was a problem saving the {0}.', [$this->humanName]));
51			}
52			}
53
54			if ($this->getRequest()->is('get')) {
55			$this->JiraForm->setData($this->JiraForm->getFormData());
56			}
57
58			$this->set([
59			'form' => $this->JiraForm,
60			'errors' => $errors
61			]);
62			}
63
64			/**
65			* The thank you page after they've submitted their report.
66			*
67			* @return void
68			*/
69			public function thankyou()
70			{
71			//
72			}
73			}
74

fr3nch13 / cakephp-jira

Pull Request — master (#8)

AppController::add() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like