AppController::add() - Code Metrics - Inspection of "Adding annotations and proper typehints." - fr3nch13/cakephp-jira - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — 1.x-dev ( 86e6f1...f6cce7 )

by Brian

created 2020-01-03 22:43 UTC

AppController::add() A

↳ Parent: AppController

Complexity

Conditions	4
Paths	5

Size

Total Lines	24
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	4.7286

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	4
eloc	14
c	2
b	0
f	0
nc	5
nop	0
dl	0
loc	24
ccs	9
cts	14
cp	0.6429
crap	4.7286
rs	9.7998

<?php

/**
 * AppController
 */

namespace Fr3nch13\Jira\Controller;

use App\Controller\AppController as BaseController;
use Fr3nch13\Jira\Form\AppForm as JiraForm;

/**
 * App Controller
 *
 * The base controller for the jira plugin.
 *
 * -----------------------------
 * Inherited:
 *
 * {@inheritdoc}
 *
 */
class AppController extends BaseController
{
    /**
     * Human name of this object.
     * @var string
     */
    public $humanName = '';

    /**
     * The form object.
     * @var object
     */
    public $JiraForm;

    /**
     * Initialize method
     *
     * @return void
     */
    public function initialize(): void
    {
        parent::initialize();

        $this->modelClass = false;

        $this->humanName = __('Task');
        $this->JiraForm = new JiraForm();
    }

    /**
     * The html form.
     *
     * @return \Cake\Http\Response|null Redirects on success.
     */
    public function add(): ?\Cake\Http\Response
    {
        $errors = [];
        if ($this->getRequest()->is('post')) {
            if ($this->JiraForm->execute($this->getRequest()->getData())) {
                $this->Flash->success(__('The {0} has been saved.', [$this->humanName]));

                return $this->redirect(['action' => 'thankyou', '?' => ['type' => $this->humanName]]);
            } else {
                $errors = $this->JiraForm->getErrors();
                $this->Flash->error(__('There was a problem saving the {0}.', [$this->humanName]));
            }
        }

        if ($this->getRequest()->is('get')) {
            $this->JiraForm->setData($this->JiraForm->getFormData());
        }

        $this->set([
            'form' => $this->JiraForm,
            'errors' => $errors,
        ]);

        return null;
    }

    /**
     * The thank you page after they've submitted their report.
     *
     * @return void
     */
    public function thankyou(): void
    {
        //
    }
}


1		<?php
2
3		/**
4		* AppController
5		*/
6
7		namespace Fr3nch13\Jira\Controller;
8
9		use App\Controller\AppController as BaseController;
10		use Fr3nch13\Jira\Form\AppForm as JiraForm;
11
12		/**
13		* App Controller
14		*
15		* The base controller for the jira plugin.
16		*
17		* -----------------------------
18		* Inherited:
19		*
20		* {@inheritdoc}
21		*
22		*/
23		class AppController extends BaseController
24		{
25		/**
26		* Human name of this object.
27		* @var string
28		*/
29		public $humanName = '';
30
31		/**
32		* The form object.
33		* @var object
34		*/
35		public $JiraForm;
36
37		/**
38		* Initialize method
39		*
40		* @return void
41		*/
42	2	public function initialize(): void
43		{
44	2	parent::initialize();
45
46	2	$this->modelClass = false;
47
48	2	$this->humanName = __('Task');
49	2	$this->JiraForm = new JiraForm();
50	2	}
51
52		/**
53		* The html form.
54		*
55		* @return \Cake\Http\Response\|null Redirects on success.
56		*/
57	1	public function add(): ?\Cake\Http\Response
58		{
59	1	$errors = [];
60	1	if ($this->getRequest()->is('post')) {
61		if ($this->JiraForm->execute($this->getRequest()->getData())) {
62		$this->Flash->success(__('The {0} has been saved.', [$this->humanName]));
63
64		return $this->redirect(['action' => 'thankyou', '?' => ['type' => $this->humanName]]);
65		} else {
66		$errors = $this->JiraForm->getErrors();
67		$this->Flash->error(__('There was a problem saving the {0}.', [$this->humanName]));
68		}
69		}
70
71	1	if ($this->getRequest()->is('get')) {
72	1	$this->JiraForm->setData($this->JiraForm->getFormData());
73		}
74
75	1	$this->set([
76	1	'form' => $this->JiraForm,
77	1	'errors' => $errors,
78		]);
79
80	1	return null;
81		}
82
83		/**
84		* The thank you page after they've submitted their report.
85		*
86		* @return void
87		*/
88	1	public function thankyou(): void
89		{
90		//
91	1	}
92		}
93

fr3nch13 / cakephp-jira

Push — 1.x-dev ( 86e6f1...f6cce7 )

AppController::add() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like