| Conditions | 4 |
| Total Lines | 57 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | # coding: utf-8 |
||
| 92 | def get_context_data(self, **kwargs): |
||
| 93 | """ |
||
| 94 | get the data of the view |
||
| 95 | |||
| 96 | data are : |
||
| 97 | 1) number of triggers enabled |
||
| 98 | 2) number of triggers disabled |
||
| 99 | 3) number of activated services |
||
| 100 | 4) list of activated services by the connected user |
||
| 101 | """ |
||
| 102 | triggers_enabled = triggers_disabled = services_activated = () |
||
| 103 | |||
| 104 | context = super(TriggerListView, self).get_context_data(**kwargs) |
||
| 105 | |||
| 106 | if self.kwargs.get('trigger_filtered_by'): |
||
| 107 | page_link = reverse('trigger_filter_by', |
||
| 108 | kwargs={'trigger_filtered_by': |
||
| 109 | self.kwargs.get('trigger_filtered_by')}) |
||
| 110 | elif self.kwargs.get('trigger_ordered_by'): |
||
| 111 | page_link = reverse('trigger_order_by', |
||
| 112 | kwargs={'trigger_ordered_by': |
||
| 113 | self.kwargs.get('trigger_ordered_by')}) |
||
| 114 | else: |
||
| 115 | page_link = reverse('home') |
||
| 116 | |||
| 117 | if self.request.user.is_authenticated(): |
||
| 118 | # get the enabled triggers |
||
| 119 | triggers_enabled = TriggerService.objects.filter( |
||
| 120 | user=self.request.user, status=1).count() |
||
| 121 | # get the disabled triggers |
||
| 122 | triggers_disabled = TriggerService.objects.filter( |
||
| 123 | user=self.request.user, status=0).count() |
||
| 124 | # get the activated services |
||
| 125 | user_service = UserService.objects.filter(user=self.request.user) |
||
| 126 | """ |
||
| 127 | List of triggers activated by the user |
||
| 128 | """ |
||
| 129 | context['trigger_filter_by'] = user_service |
||
| 130 | """ |
||
| 131 | number of service activated for the current user |
||
| 132 | """ |
||
| 133 | services_activated = user_service.count() |
||
| 134 | |||
| 135 | """ |
||
| 136 | which triggers are enabled/disabled |
||
| 137 | """ |
||
| 138 | context['nb_triggers'] = {'enabled': triggers_enabled, |
||
| 139 | 'disabled': triggers_disabled} |
||
| 140 | """ |
||
| 141 | Number of services activated |
||
| 142 | """ |
||
| 143 | context['nb_services'] = services_activated |
||
| 144 | |||
| 145 | context['page_link'] = page_link |
||
| 146 | context['fire'] = settings.DJANGO_TH.get('fire', False) |
||
| 147 | |||
| 148 | return context |
||
| 149 | |||
| 215 |