Choice - Code Metrics - Inspection of "Add Choice field type - closes #574" - formers/former - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( c60a32...d8cf68 )

by Ben
created 2019-01-31 14:45 UTC
Choice F

↳ Parent: Project
Complexity

Total Complexity
Size/Duplication

Total Lines	476
Duplicated Lines	0 %
Coupling/Cohesion

Components	1
Dependencies	4
Importance

Changes
Metric	Value
wmc	73
lcom	1
cbo	4
dl	0
loc	476
rs	2.56
c	0
b	0
f	0
21 Methods

Rating	Name	Size	Complexity
B	__construct()	19	8
A	render()	22	5
A	getSelect()	16	2
A	getOptions()	18	5
A	getOptGroup()	12	2
A	getOption()	18	4
F	getCheckables()	81	18
A	getPlaceholder()	13	3
A	setChoiceType()	11	5
B	hasValue()	12	7
A	addChoice()	6	1
A	choices()	17	4
A	range()	7	1
A	fromQuery()	6	1
A	placeholder()	6	1
A	multiple()	7	1
A	expanded()	7	1
A	inline()	6	1
A	stacked()	6	1
A	isCheckable()	4	1
A	getChoices()	4	1
How to fix Complexity

<?php
namespace Former\Form\Fields;

use Former\Helpers;
use Former\Traits\Field;
use HtmlObject\Element;
use HtmlObject\Input;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Illuminate\Container\Container;

/**
 * Everything list-related (select, multiselect, ...)
 */
class Choice extends Field
{
	/**
	 * Renders the checkables as inline
	 *
	 * @var boolean
	 */
	protected $inline = false;

	/**
	 * The choice's placeholder
	 *
	 * @var string
	 */
	private $placeholder = null;

	/**
	 * The choice's options
	 *
	 * @var array
	 */
	protected $options = [
        'isMultiple' => false,
        'isExpanded' => false,
    ];

	/**
	 * The choice's choices
	 *
	 * @var array
	 */
	protected $choices = [];

	/**
	 * The choice's element
	 *
	 * @var string
	 */
	protected $element = 'choice';

	/**
	 * The choice's self-closing state
	 *
	 * @var boolean
	 */
	protected $isSelfClosing = false;

	////////////////////////////////////////////////////////////////////
	/////////////////////////// CORE METHODS ///////////////////////////
	////////////////////////////////////////////////////////////////////

	/**
	 * Easier arguments order for selects
	 *
	 * @param Container $app        The Container instance
	 * @param string    $type       select
	 * @param string    $name       Field name
	 * @param string    $label      Its label
	 * @param array     $choices    The choice's choices
	 * @param string    $selected   The selected choice(s)
	 * @param array     $attributes Attributes
	 */
	public function __construct(Container $app, $type, $name, $label, $choices, $selected, $attributes)
	{
		if ($selected) {
			$this->value = $selected;
		}
		if ($choices) {

			$this->choices($choices);
		}
		
		parent::__construct($app, $type, $name, $label, $selected, $attributes);
		
		$this->setChoiceType();

		// Nested models population
		if (str_contains($this->name, '.') and is_array($this->value) and !empty($this->value) and is_string($this->value[key($this->value)])) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
			$this->fromQuery($this->value);
			$this->value = $selected ?: null;
		}
	}

	/**
	 * Renders the choice
	 *
	 * @return string A <select> tag
	 */
	public function render()
	{
		$choiceType = $this->getType();
		$this->setFieldClasses();

		if (!isset($this->attributes['id'])) {
			$this->setAttribute('id', $this->name);
		}

		switch ($choiceType) {
			case 'select':
				$field = $this->getSelect();
				break;
			case 'checkbox':
			case 'radio':
				$field = $this->getCheckables($choiceType);
				break;
		}
		$this->value = null;
		$content = $field->render();
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		return $content;
	}

	public function getSelect()
	{
		$field = Element::create('select', null, $this->attributes);

		$name = $this->name;
		if ($this->options['isMultiple']) {
			$field->multiple();
			$name .= '[]';
		}
		
		$field->setAttribute('name', $name);

		$field->nest($this->getOptions());

		return $field;
	}

	public function getOptions()
	{
		$children = [];
		
		// Add placeholder text if any
		if ($placeholder = $this->getPlaceholder()) {
			$children[] = $placeholder;
		}

		foreach ($this->choices as $key => $value) {
			if (is_array($value) and !isset($value['value'])) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
				$children[] = $this->getOptGroup($key, $value);
			} else {
				$children[] = $this->getOption($key, $value);
			}
		}
		return $children;
	}

	public function getOptGroup($label, $options)
	{
		$element = Element::create('optgroup')->label($label);
		$children = [];
		foreach ($options as $key => $value) {
			$option = $this->getOption($key, $value);
			$children[] = $option;
		}
		$element->nest($children);

		return $element;
	}

	public function getOption($key, $value)
	{
		if (is_array($value) and isset($value['value'])) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
			$attributes = $value;
			$text = $key;
			$key = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		} else {
			$attributes = array('value' => $key);
			$text = $value;
		}

		$element = Element::create('option', $text, $attributes);
		if ($this->hasValue($attributes['value'])) {
			$element->selected('selected');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
		}

		return $element;
	}

	public function getCheckables($choiceType)
	{
		if (!(is_array($this->value) || $this->value instanceof \ArrayAccess)) {
			$this->value = explode(',', $this->value);

		}

		$disabled = isset($this->attributes['disabled']);
		unset($this->attributes['disabled']);

		$field = Element::create('div', null, $this->attributes);

		$children = [];
		foreach ($this->choices as $key => $value) {
			$attributes = [];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

			if (is_array($value) and isset($value['value'])) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
				$attributes = $value;
				$label = $key;
				$inputValue = $value['value'];
			} else {
				$attributes = [];
				$label = $value;
				$inputValue = $key;
			}

			if ($disabled) {
				$attributes['disabled'] = true;
			}

			if(isset($attributes['name'])) {
				$name = $attributes['name'];
				unset($attributes['name']);
			} else {
				$name = $this->name;
			}
			if ($this->options['isMultiple']) {
				$name .= '[]';
			}
		
			if(!isset($attributes['id'])) {
				$attributes['id'] = $this->id.'_'.count($children);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
			}

			// If inline items, add class
			$isInline = $this->inline ? ' '.$this->app['former.framework']->getInlineLabelClass($this) : null;

			// In Bootsrap 3, don't append the the checkable type (radio/checkbox) as a class if
			// rendering inline.
			$class = $this->app['former']->framework() == 'TwitterBootstrap3' ? trim($isInline) : $choiceType.$isInline;

			$element = Input::create($choiceType, $name, $inputValue, $attributes);
			
			// $element->setAttribute('name', $name);


			if ($this->hasValue($inputValue)) {
				$element->checked('checked');
			}
			// $attributes['value'] = $key;

			if (!$label) {
				$element = (is_object($field)) ? $field->render() : $field;
			} else {
				$rendered = $element->render();
				$labelElement = Element::create('label', $rendered.$label);
				$element = $labelElement->for($attributes['id'])->class($class);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
			}
			
			// If BS3, if checkables are stacked, wrap them in a div with the checkable type
			if (!$isInline && $this->app['former']->framework() == 'TwitterBootstrap3') {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
				$wrapper = Element::create('div', $element->render())->class($choiceType);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
				if ($disabled) {
					$wrapper->addClass('disabled');
				}
				$element = $wrapper;
			}

			$children[] = $element;
		}
		$field->nest($children);
		
		return $field;
	}

	/**
	 * Get the choice's placeholder
	 *
	 * @return Element
	 */
	protected function getPlaceholder()
	{
		if (!$this->placeholder) {
			return false;
		}

		$attributes = array('value' => '', 'disabled' => 'disabled');
		if (!(array)$this->value) {
			$attributes['selected'] = 'selected';
		}

		return Element::create('option', $this->placeholder, $attributes);
	}

	/**
	 * Sets the element's type based on options
	 *
	 * @return this
	 */
	protected function setChoiceType()
	{
		if ($this->options['isExpanded'] && !$this->options['isMultiple']) {
			$this->setType('radio');
		} elseif ($this->options['isExpanded'] && $this->options['isMultiple']) {
			$this->setType('checkbox');
		} else {
			$this->setType('select');
		}
		return $this;
	}

	/**
	 * Select a value in the field's children
	 *
	 * @param mixed   $value
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
	 *
	 * @return bool
	 */
	protected function hasValue($choiceValue)
	{
		foreach ((array)$this->value as $key => $value) {
			if (is_object($value) && method_exists($value, 'getKey')) {
				$value = $value->getKey();
			}
			if ($choiceValue === $value || is_numeric($value) && $choiceValue === (int)$value) {
				return true;
			}
		}
		return false;
	}

	////////////////////////////////////////////////////////////////////
	////////////////////////// FIELD METHODS ///////////////////////////
	////////////////////////////////////////////////////////////////////

	/**
	 * Set the choices
	 *
	 * @param  array   $_choices     The choices as an array
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
	 * @param  mixed   $selected     Facultative selected entry
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
	 * @param  boolean $valuesAsKeys Whether the array's values should be used as
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
	 *                               the option's values instead of the array's keys
	 */
	public function addChoice($value, $key = null)
	{
		$this->choices[$key ?? $value] = $value;

		return $this;
	}

	/**
	 * Set the choices
	 *
	 * @param  array   $_choices     The choices as an array
	 * @param  mixed   $selected     Facultative selected entry
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
	 * @param  boolean $valuesAsKeys Whether the array's values should be used as
	 *                               the option's values instead of the array's keys
	 */
	public function choices($_choices, $valuesAsKeys = false)
	{
		$choices = (array) $_choices;

		// If valuesAsKeys is true, use the values as keys
		if ($valuesAsKeys) {
			foreach ($choices as $value) {
				$this->addChoice($value, $value);
			}
		} else {
			foreach ($choices as $key => $value) {
				$this->addChoice($value, $key);
			}
		}

		return $this;
	}

	/**
	 * Creates a list of choices from a range
	 *
	 * @param  integer $from
	 * @param  integer $to
	 * @param  integer $step
	 */
	public function range($from, $to, $step = 1)
	{
		$range = range($from, $to, $step);
		$this->choices($range, true);

		return $this;
	}

	/**
	 * Use the results from a Fluent/Eloquent query as choices
	 *
	 * @param  array           $results    An array of Eloquent models
	 * @param  string|function $text       The value to use as text
	 * @param  string|array    $attributes The data to use as attributes
	 * @param  string	       $selected   The default selected item
	 */
	public function fromQuery($results, $text = null, $attributes = null, $selected = null)
	{
		$this->choices(Helpers::queryToArray($results, $text, $attributes))->value($selected);


		return $this;
	}

	/**
	 * Add a placeholder to the current select
	 *
	 * @param  string $placeholder The placeholder text
	 */
	public function placeholder($placeholder)
	{
		$this->placeholder = Helpers::translate($placeholder);

		return $this;
	}
	
	/**
	 * Set isMultiple
	 *
	 * @param boolean $isMultiple
	 * @return $this
	 */
	public function multiple($isMultiple = true)
	{
		$this->options['isMultiple'] = $isMultiple;
		$this->setChoiceType();

		return $this;
	}
	
	/**
	 * Set isExpanded
	 *
	 * @param boolean $isExpanded
	 * @return $this
	 */
	public function expanded($isExpanded = true)
	{
		$this->options['isExpanded'] = $isExpanded;
		$this->setChoiceType();

		return $this;
	}

	/**
	 * Set the choices as inline (for expanded items)
	 */
	public function inline($isInline = true)
	{
		$this->inline = $isInline;

		return $this;
	}

	/**
	 * Set the choices as stacked (for expanded items)
	 */
	public function stacked($isStacked = true)
	{
		$this->inline = !$isStacked;

		return $this;
	}

	/**
	 * Check if field is a checkbox or a radio
	 *
	 * @return boolean
	 */
	public function isCheckable()
	{
		return $this->options['isExpanded'];
	}

	////////////////////////////////////////////////////////////////////
	////////////////////////////// HELPERS /////////////////////////////
	////////////////////////////////////////////////////////////////////

	/**
	 * Returns the current choices in memory for manipulations
	 *
	 * @return array The current choices array
	 */
	public function getChoices()
	{
		return $this->choices;
	}
	
}

Push — master ( c60a32...d8cf68 )

Choice F

Complexity

Size/Duplication

Coupling/Cohesion

Importance

21 Methods

How to fix Complexity

Complex Class

Logical Operators are used for Control-Flow

Available Fixes

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

formers / former

Push — master ( c60a32...d8cf68 )

Choice F

Complexity

Size/Duplication

Coupling/Cohesion

Importance

21 Methods

How to fix Complexity

Complex Class

Logical Operators are used for Control-Flow

Available Fixes

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Duplication Side-by-Side

Filter issues like
