forkcms / forkcms

src/Backend/Modules/Analytics/Actions/Settings.php

<?php

namespace Backend\Modules\Analytics\Actions;

use Backend\Core\Engine\Base\ActionIndex;
use Backend\Core\Engine\Model;
use Backend\Modules\Analytics\Form\SettingsType;

/**
 * This is the settings-action (default), it will be used to couple your analytics
 * account
 */
final class Settings extends ActionIndex
{
    public function execute(): void
    {
        parent::execute();

        $settingsForm = new SettingsType(
            'settings',
            $this->get('fork.settings'),

It seems like $this->get('fork.settings') can also be of type null; however, parameter $settings of Backend\Modules\Analytics\Form\SettingsType::__construct() does only seem to accept Common\ModulesSettings, maybe add an additional type check?

            $this->get('analytics.google_analytics_service')

It seems like $this->get('analytics.google_analytics_service') can also be of type null; however, parameter $googleServiceAnalytics of Backend\Modules\Analytics\Form\SettingsType::__construct() does only seem to accept Google_Service_Analytics, maybe add an additional type check?

        );

        if ($settingsForm->handle()) {
            $this->redirect(Model::createUrlForAction('Settings'));
        }
        $settingsForm->parse($this->template);

        if ($this->get('fork.settings')->get($this->getModule(), 'web_property_id')) {
            $this->template->assign(
                'web_property_id',
                $this->get('fork.settings')->get($this->getModule(), 'web_property_id')
            );
        }
        if ($this->get('fork.settings')->get($this->getModule(), 'profile')) {
            $this->template->assign(
                'profile',
                $this->get('fork.settings')->get($this->getModule(), 'profile')
            );
        }

        $this->display();
    }
}