Issues in Method.php - Fixed Issues - Inspection of "PHPDoc updates" - forkcms/fork-cms-module-media-library-importer - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 0ab104...bfda64 )

by Jeroen

created 2017-04-18 09:09 UTC

Domain/MediaItemImport/Method.php (1 issue)

Labels

Duplication 1

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Backend\Modules\MediaLibraryImporter\Domain\MediaItemImport;

final class Method
{
    const COPY = 'copy';
    const DOWNLOAD = 'download';
    const MOVE = 'move';
    const POSSIBLE_VALUES = [
        self::COPY,
        self::DOWNLOAD,
        self::MOVE
    ];

    /** @var string */
    private $method;

    /**
     * @param string $method
     */
    private function __construct(string $method)

    {
        if (!in_array($method, self::POSSIBLE_VALUES, true)) {
            throw new \InvalidArgumentException(
                'Invalid value for possible MediaItemImport method. Possible values; ' . implode(',', self::POSSIBLE_VALUES)
            );
        }

        $this->method = $method;
    }

    /**
     * @param string $method
     * @return Method
     */
    public static function fromString(string $method): Method
    {
        return new self($method);
    }

    /**
     * @return string
     */
    public function __toString(): string
    {
        return $this->method;
    }

    /**
     * @param Method $method
     * @return bool
     */
    public function equals(Method $method): bool
    {
        return $method->method === $this->method;
    }

    /**
     * @return Method
     */
    public static function copy(): Method
    {
        return new self(self::COPY);
    }

    /**
     * @return bool
     */
    public function isCopy(): bool
    {
        return $this->equals(self::copy());
    }

    /**
     * @return Method
     */
    public static function move(): Method
    {
        return new self(self::MOVE);
    }

    /**
     * @return bool
     */
    public function isMove(): bool
    {
        return $this->equals(self::move());
    }

    /**
     * @return Method
     */
    public static function download(): Method
    {
        return new self(self::DOWNLOAD);
    }

    /**
     * @return bool
     */
    public function isDownload(): bool
    {
        return $this->equals(self::download());
    }

    /**
     * @return string
     */
    public function getMethod(): string
    {
        return $this->method;
    }
}


1		<?php
2
3		namespace Backend\Modules\MediaLibraryImporter\Domain\MediaItemImport;
4
5		final class Method
6		{
7		const COPY = 'copy';
8		const DOWNLOAD = 'download';
9		const MOVE = 'move';
10		const POSSIBLE_VALUES = [
11		self::COPY,
12		self::DOWNLOAD,
13		self::MOVE
14		];
15
16		/** @var string */
17		private $method;
18
19		/**
20		* @param string $method
21		*/
22	View Code Duplication	private function __construct(string $method)
		1 ignored issue – show Duplication introduced 2017-04-18 07:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
23		{
24		if (!in_array($method, self::POSSIBLE_VALUES, true)) {
25		throw new \InvalidArgumentException(
26		'Invalid value for possible MediaItemImport method. Possible values; ' . implode(',', self::POSSIBLE_VALUES)
27		);
28		}
29
30		$this->method = $method;
31		}
32
33		/**
34		* @param string $method
35		* @return Method
36		*/
37		public static function fromString(string $method): Method
38		{
39		return new self($method);
40		}
41
42		/**
43		* @return string
44		*/
45		public function __toString(): string
46		{
47		return $this->method;
48		}
49
50		/**
51		* @param Method $method
52		* @return bool
53		*/
54		public function equals(Method $method): bool
55		{
56		return $method->method === $this->method;
57		}
58
59		/**
60		* @return Method
61		*/
62		public static function copy(): Method
63		{
64		return new self(self::COPY);
65		}
66
67		/**
68		* @return bool
69		*/
70		public function isCopy(): bool
71		{
72		return $this->equals(self::copy());
73		}
74
75		/**
76		* @return Method
77		*/
78		public static function move(): Method
79		{
80		return new self(self::MOVE);
81		}
82
83		/**
84		* @return bool
85		*/
86		public function isMove(): bool
87		{
88		return $this->equals(self::move());
89		}
90
91		/**
92		* @return Method
93		*/
94		public static function download(): Method
95		{
96		return new self(self::DOWNLOAD);
97		}
98
99		/**
100		* @return bool
101		*/
102		public function isDownload(): bool
103		{
104		return $this->equals(self::download());
105		}
106
107		/**
108		* @return string
109		*/
110		public function getMethod(): string
111		{
112		return $this->method;
113		}
114		}
115

forkcms / fork-cms-module-media-library-importer

Push — master ( 0ab104...bfda64 )

Domain/MediaItemImport/Method.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like